-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support drive anti-affinity for volumes #823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
unique-alloc
branch
3 times, most recently
from
August 14, 2023 10:26
e9268a4
to
988c1a6
Compare
Praveenrajmani
requested review from
harshavardhana,
balamurugana,
cniackz and
kanagarajkm
August 18, 2023 04:45
Praveenrajmani
force-pushed
the
unique-alloc
branch
2 times, most recently
from
August 18, 2023 05:39
2d86a32
to
3dc3f03
Compare
Praveenrajmani
force-pushed
the
unique-alloc
branch
from
September 12, 2023 12:46
e04f329
to
54cd3c0
Compare
Praveenrajmani
force-pushed
the
unique-alloc
branch
2 times, most recently
from
September 13, 2023 09:29
fcc663d
to
967c749
Compare
Praveenrajmani
force-pushed
the
unique-alloc
branch
from
September 13, 2023 15:18
967c749
to
5cb3558
Compare
Praveenrajmani
force-pushed
the
unique-alloc
branch
from
September 14, 2023 06:03
5cb3558
to
f3d1d28
Compare
Some optimal setups would require volumes to be allocated on unique disks. ie, not more than one volume per disk. By default, the volume scheduling algorithm choses the drive based on most free capacity. This will end up allocating more than one volumes per disk. This PR provides a way for such optimal setups, by using the storage class parameters. Using a storage class with `directpv.min.io/volume-claim-id: <uuid>` parameter enables unique allocation for PVCs. This unique allocation id enables the one-to-one cardinality for the drives and volumes.
Praveenrajmani
force-pushed
the
unique-alloc
branch
from
September 15, 2023 05:39
f3d1d28
to
5e1a63b
Compare
balamurugana
approved these changes
Sep 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimal setups would require volumes to be allocated on unique disks. ie, not more than one volume per disk.
By default, the volume scheduling algorithm choses the drive based on most free capacity. This will end up allocating more than one volumes per disk.
This PR provides a way for such optimal setups, by using the storage class parameters. Using a storage class with
directpv.min.io/volume-claim-id: XXX
parameter enables unique allocation for PVCs. This unique allocation id enables the one-to-one cardinality for the drives and volumes.Steps to test :
directpv.min.io/volume-claim-id: <any-uid>