-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for bulk-init based on ellipses
- Loading branch information
1 parent
ac08ecb
commit 166ca59
Showing
11 changed files
with
483 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| // This file is part of MinIO DirectPV | ||
| // Copyright (c) 2024 MinIO, Inc. | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "os" | ||
| "strings" | ||
| "sync" | ||
|
|
||
| directpvtypes "github.com/minio/directpv/pkg/apis/directpv.min.io/types" | ||
| "github.com/minio/directpv/pkg/consts" | ||
| devicepkg "github.com/minio/directpv/pkg/device" | ||
| "github.com/minio/directpv/pkg/ellipsis" | ||
| "github.com/minio/directpv/pkg/initrequest" | ||
| "github.com/minio/directpv/pkg/sys" | ||
| "github.com/minio/directpv/pkg/utils" | ||
| "github.com/spf13/cobra" | ||
| "k8s.io/klog/v2" | ||
| ) | ||
|
|
||
| var drivesArgs []string | ||
| var initAll bool | ||
|
|
||
| var bulkInitCmd = &cobra.Command{ | ||
| Use: "bulk-init --drives [DRIVE-ELLIPSIS...]", | ||
| Short: "Bulk initialize the devices", | ||
| SilenceUsage: true, | ||
| SilenceErrors: true, | ||
| Hidden: true, | ||
| RunE: func(c *cobra.Command, _ []string) error { | ||
| if err := sys.Mkdir(consts.MountRootDir, 0o755); err != nil && !errors.Is(err, os.ErrExist) { | ||
| return err | ||
| } | ||
| switch len(drivesArgs) { | ||
| case 0: | ||
| return errors.New("--drives must be provided") | ||
| case 1: | ||
| if drivesArgs[0] == "*" { | ||
| initAll = true | ||
| } | ||
| } | ||
|
|
||
| var drives []string | ||
| for i := range drivesArgs { | ||
| drivesArgs[i] = strings.TrimSpace(utils.TrimDevPrefix(drivesArgs[i])) | ||
| if drivesArgs[i] == "" { | ||
| return fmt.Errorf("empty drive name") | ||
| } | ||
| result, err := ellipsis.Expand(drivesArgs[i]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| drives = append(drives, result...) | ||
| } | ||
| if !initAll && len(drives) == 0 { | ||
| return errors.New("invalid ellipsis input; no drives selected") | ||
| } | ||
| return startBulkInit(c.Context(), drives) | ||
| }, | ||
| } | ||
|
|
||
| func init() { | ||
| bulkInitCmd.PersistentFlags().BoolVar(&dryRunFlag, "dry-run", dryRunFlag, "No modify mode") | ||
| bulkInitCmd.PersistentFlags().StringSliceVarP(&drivesArgs, "drives", "d", drivesArgs, "drives to be initialized; supports ellipses pattern e.g. sd{a...z}") | ||
| } | ||
|
|
||
| func startBulkInit(ctx context.Context, drives []string) error { | ||
| var cancel context.CancelFunc | ||
| ctx, cancel = context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| initRequestHandler, err := initrequest.NewHandler( | ||
| ctx, | ||
| nodeID, | ||
| map[string]string{ | ||
| string(directpvtypes.TopologyDriverIdentity): identity, | ||
| string(directpvtypes.TopologyDriverRack): rack, | ||
| string(directpvtypes.TopologyDriverZone): zone, | ||
| string(directpvtypes.TopologyDriverRegion): region, | ||
| string(directpvtypes.TopologyDriverNode): string(nodeID), | ||
| }, | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to create initrequest handler; %v", err) | ||
| } | ||
|
|
||
| devices, err := devicepkg.Probe() | ||
| if err != nil { | ||
| return fmt.Errorf("unable to probe devices; %v", err) | ||
| } | ||
|
|
||
| var filteredDevices []devicepkg.Device | ||
| for _, device := range devices { | ||
| klog.Infoln(device.Name) | ||
| if !device.Available() { | ||
| continue | ||
| } | ||
| if initAll || utils.Contains(drives, device.Name) { | ||
| filteredDevices = append(filteredDevices, device) | ||
| } | ||
| } | ||
|
|
||
| if len(filteredDevices) == 0 { | ||
| return errors.New("no available drives selected to initialize") | ||
| } | ||
|
|
||
| var wg sync.WaitGroup | ||
| var failed bool | ||
| for i := range filteredDevices { | ||
| wg.Add(1) | ||
| go func(i int, device devicepkg.Device, force bool) { | ||
| defer wg.Done() | ||
| if dryRunFlag { | ||
| klog.Infof("\n[DRY-RUN] initializing device %v with force: %v", device.Name, force) | ||
| return | ||
| } | ||
| if err := initRequestHandler.InitDevice(device, force); err != nil { | ||
| failed = true | ||
| klog.ErrorS(err, "unable to init device %v", device.Name) | ||
| } | ||
| }(i, filteredDevices[i], filteredDevices[i].FSType() != "") | ||
| } | ||
| wg.Wait() | ||
|
|
||
| if failed { | ||
| return errors.New("failed to initialize all the drives") | ||
| } | ||
|
|
||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| annotations: | ||
| rbac.authorization.kubernetes.io/autoupdate: "true" | ||
| creationTimestamp: null | ||
| labels: | ||
| directpv.min.io/created-by: bulk-init | ||
| directpv.min.io/version: v1beta1 | ||
| name: directpv-bulk-init | ||
| rules: | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - events | ||
| verbs: | ||
| - create | ||
| - list | ||
| - patch | ||
| - update | ||
| - watch | ||
| - apiGroups: | ||
| - directpv.min.io | ||
| resources: | ||
| - directpvdrives | ||
| verbs: | ||
| - create | ||
| - get |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| annotations: | ||
| rbac.authorization.kubernetes.io/autoupdate: "true" | ||
| creationTimestamp: null | ||
| labels: | ||
| directpv.min.io/created-by: bulk-init | ||
| directpv.min.io/version: v1beta1 | ||
| name: directpv-bulk-init | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: directpv-bulk-init | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: directpv-bulk-init | ||
| namespace: directpv |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
|
|
||
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| labels: | ||
| directpv.min.io/created-by: bulk-init | ||
| directpv.min.io/version: v1beta1 | ||
| name: bulk-init | ||
| namespace: directpv | ||
| spec: | ||
| ttlSecondsAfterFinished: 3600 | ||
| backoffLimit: 0 | ||
| template: | ||
| metadata: | ||
| name: bulk-init | ||
| namespace: directpv | ||
| spec: | ||
| containers: | ||
| - args: | ||
| - bulk-init | ||
| - -v=3 | ||
| - --kube-node-name=$(KUBE_NODE_NAME) | ||
| - --drives=$(DRIVE_ELLIPSES) | ||
| env: | ||
| - name: KUBE_NODE_NAME | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: spec.nodeName | ||
| image: quay.io/minio/directpv@sha256:83fd05fe114ed15c3975333c90cbe18c782d9c4d5c7ad6fdb8cc835e380ba505 | ||
| name: bulk-init | ||
| resources: {} | ||
| securityContext: | ||
| privileged: true | ||
| terminationMessagePath: /var/log/driver-termination-log | ||
| terminationMessagePolicy: FallbackToLogsOnError | ||
| volumeMounts: | ||
| - mountPath: /var/lib/directpv/ | ||
| mountPropagation: Bidirectional | ||
| name: directpv-common-root | ||
| - mountPath: /sys | ||
| mountPropagation: Bidirectional | ||
| name: sysfs | ||
| - mountPath: /dev | ||
| mountPropagation: HostToContainer | ||
| name: devfs | ||
| readOnly: true | ||
| - mountPath: /run/udev/data | ||
| mountPropagation: Bidirectional | ||
| name: run-udev-data-dir | ||
| readOnly: true | ||
| restartPolicy: Never | ||
| hostPID: true | ||
| serviceAccountName: directpv-bulk-init | ||
| volumes: | ||
| - hostPath: | ||
| path: /var/lib/directpv/ | ||
| type: DirectoryOrCreate | ||
| name: directpv-common-root | ||
| - hostPath: | ||
| path: /sys | ||
| type: DirectoryOrCreate | ||
| name: sysfs | ||
| - hostPath: | ||
| path: /dev | ||
| type: DirectoryOrCreate | ||
| name: devfs | ||
| - hostPath: | ||
| path: /run/udev/data | ||
| type: DirectoryOrCreate | ||
| name: run-udev-data-dir |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| creationTimestamp: null | ||
| finalizers: | ||
| - foregroundDeletion | ||
| labels: | ||
| directpv.min.io/version: v1beta1 | ||
| pod-security.kubernetes.io/enforce: privileged | ||
| name: directpv | ||
| spec: {} | ||
| status: {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
|
|
||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| creationTimestamp: null | ||
| labels: | ||
| directpv.min.io/created-by: bulk-init | ||
| directpv.min.io/version: v1beta1 | ||
| name: directpv-bulk-init | ||
| namespace: directpv |
Oops, something went wrong.