fix: properly reports common :gen_server abnormal exits

lib/tower_honeybadger/honeybadger/notice.ex

@@ -28,7 +28,7 @@ defmodule TowerHoneybadger.Honeybadger.Notice do
         stacktrace: stacktrace,
         plug_conn: plug_conn
       }) do
-    error_notice("(exit)", reason, stacktrace, plug_conn)
+    error_notice("(exit)", Exception.format_exit(reason), stacktrace, plug_conn)
   end
 
   defp error_notice(class, message, stacktrace, plug_conn) do

test/tower_honeybadger_test.exs

@@ -65,7 +65,7 @@
 
       capture_log(fn ->
         in_unlinked_process(fn ->
           1 / 0
         end)
       end)
     end)
@@ -126,7 +126,7 @@
             %{
               "error" => %{
                 "class" => "(exit)",
-                "message" => "abnormal",
+                "message" => ":abnormal",
                 "backtrace" => backtrace_entries
               },
               "server" => %{
@@ -159,6 +159,51 @@
     end)
   end
 
+  test "reports :gen_server bad exit", %{bypass: bypass} do
+    waiting_for(fn done ->
+      Bypass.expect_once(bypass, "POST", "/notices", fn conn ->
+        {:ok, body, conn} = Plug.Conn.read_body(conn)
+
+        assert(
+          {
+            :ok,
+            %{
+              "error" => %{
+                "class" => "(exit)",
+                "message" => "bad return value: \"bad value\"",
+                "backtrace" => backtrace_entries
+              },
+              "server" => %{
+                "environment_name" => "test"
+              }
+            }
+          } = Jason.decode(body)
+        )
+
+        assert(
+          %{
+            "file" => "test/tower_honeybadger_test.exs",
+            "method" =>
+              ~s(anonymous fn/0 in TowerHoneybadgerTest."test reports :gen_server bad exit"/1),
+            "number" => 201
+          } = List.first(backtrace_entries)
+        )
+
+        done.()
+
+        conn
+        |> Plug.Conn.put_resp_content_type("application/json")
+        |> Plug.Conn.resp(200, Jason.encode!(%{"id" => "123"}))
+      end)
+
+      capture_log(fn ->
+        in_unlinked_process(fn ->
+          exit({:bad_return_value, "bad value"})
+        end)
+      end)
+    end)
+  end
+
   defp waiting_for(fun) do
     # ref message synchronization trick copied from
     # https://github.com/PSPDFKit-labs/bypass/issues/112