Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove extra memory copy of bf16/bf16 brustforce search #38751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cqy123456
Copy link
Contributor

issue: #37798
related knowhere pr: zilliztech/knowhere#980

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (aa0a87e) to head (540d15b).

Files with missing lines Patch % Lines
internal/core/src/query/SearchBruteForce.cpp 66.66% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aa0a87e) and HEAD (540d15b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa0a87e) HEAD (540d15b)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38751       +/-   ##
===========================================
- Coverage   81.13%   69.53%   -11.61%     
===========================================
  Files        1387      296     -1091     
  Lines      196268    26526   -169742     
===========================================
- Hits       159251    18445   -140806     
+ Misses      31421     8081    -23340     
+ Partials     5596        0     -5596     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.53% <66.66%> (-0.02%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/query/SearchBruteForce.cpp 78.26% <66.66%> (-1.47%) ⬇️

... and 1091 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 26, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@@ -238,13 +222,11 @@ DispatchBruteForceIteratorByDataType(const knowhere::DataSetPtr& base_dataset,
base_dataset, query_dataset, config, bitset);
break;
case DataType::VECTOR_FLOAT16:
//todo: if knowhere support real fp16/bf16 bf, change it
return knowhere::BruteForce::AnnIterator<float>(
return knowhere::BruteForce::AnnIterator<float16>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to update unittest/test_bf.cpp to cover these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants