-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: remove extra memory copy of bf16/bf16 brustforce search #38751
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38751 +/- ##
===========================================
- Coverage 81.13% 69.53% -11.61%
===========================================
Files 1387 296 -1091
Lines 196268 26526 -169742
===========================================
- Hits 159251 18445 -140806
+ Misses 31421 8081 -23340
+ Partials 5596 0 -5596
|
@cqy123456 cpp-unit-test check failed, comment |
@cqy123456 go-sdk check failed, comment |
@cqy123456 cpp-unit-test check failed, comment |
@cqy123456 go-sdk check failed, comment |
Signed-off-by: cqy123456 <[email protected]>
@@ -238,13 +222,11 @@ DispatchBruteForceIteratorByDataType(const knowhere::DataSetPtr& base_dataset, | |||
base_dataset, query_dataset, config, bitset); | |||
break; | |||
case DataType::VECTOR_FLOAT16: | |||
//todo: if knowhere support real fp16/bf16 bf, change it | |||
return knowhere::BruteForce::AnnIterator<float>( | |||
return knowhere::BruteForce::AnnIterator<float16>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to update unittest/test_bf.cpp to cover these changes.
issue: #37798
related knowhere pr: zilliztech/knowhere#980