Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix checkGeneralCapacity slowly #37976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Cache the general count to speed up checkGeneralCapacity.

issue: #37630

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (5e807c3) to head (328dd73).

Files with missing lines Patch % Lines
internal/rootcoord/meta_table.go 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37976       +/-   ##
===========================================
+ Coverage   68.87%   81.07%   +12.20%     
===========================================
  Files         289     1360     +1071     
  Lines       25484   190842   +165358     
===========================================
+ Hits        17551   154728   +137177     
- Misses       7933    30623    +22690     
- Partials        0     5491     +5491     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.24% <94.73%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/constrant.go 100.00% <100.00%> (ø)
internal/rootcoord/create_collection_task.go 90.31% <100.00%> (ø)
internal/rootcoord/create_partition_task.go 91.39% <100.00%> (ø)
internal/rootcoord/meta_table.go 82.82% <92.30%> (ø)

... and 1067 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

czs007 pushed a commit that referenced this pull request Nov 25, 2024
Cache the general count to speed up checkGeneralCapacity.

issue: #37630

pr: #37976

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants