Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Refine Replica manager colle2Replicas secondary index (#37906) #37970

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37906
Related to #37630

This PR add a new util coll2Replicas secondary index to reduce map access & iteration while get replicas by collection


…s-io#37906)

Related to milvus-io#37630

This PR add a new util coll2Replicas secondary index to reduce map
access & iteration while get replicas by collection

---------

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (4aca68a) to head (5bee7e5).
Report is 10 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/replica_manager.go 90.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37970      +/-   ##
==========================================
+ Coverage   72.24%   80.63%   +8.38%     
==========================================
  Files        1069     1069              
  Lines      166979   166986       +7     
==========================================
+ Hits       120641   134653   +14012     
+ Misses      41919    27927   -13992     
+ Partials     4419     4406      -13     
Files with missing lines Coverage Δ
internal/querycoordv2/meta/replica_manager.go 82.20% <90.47%> (+0.39%) ⬆️

... and 233 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8601f3e into milvus-io:2.4 Nov 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants