Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the db information in the dml message #37969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 25, 2024

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (fbb68ca) to head (3acbd48).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_upsert.go 45.45% 5 Missing and 1 partial ⚠️
internal/proxy/task_insert.go 42.85% 3 Missing and 1 partial ⚠️
internal/proxy/task_upsert_streaming.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37969      +/-   ##
==========================================
- Coverage   81.07%   81.07%   -0.01%     
==========================================
  Files        1360     1360              
  Lines      190775   190789      +14     
==========================================
+ Hits       154671   154682      +11     
+ Misses      30620    30618       -2     
- Partials     5484     5489       +5     
Components Coverage Δ
Client 72.33% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.24% <65.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.42% <100.00%> (+0.03%) ⬆️
internal/proxy/msg_pack.go 73.33% <100.00%> (+0.27%) ⬆️
internal/proxy/task_delete.go 92.41% <100.00%> (-0.02%) ⬇️
internal/proxy/task_delete_streaming.go 72.34% <100.00%> (-2.66%) ⬇️
internal/proxy/task_insert.go 74.07% <42.85%> (-1.05%) ⬇️
internal/proxy/task_upsert_streaming.go 0.00% <0.00%> (ø)
internal/proxy/task_upsert.go 70.77% <45.45%> (-0.66%) ⬇️

... and 23 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun cpp-unit-test

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants