Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent simultaneous balance of segments and channels (#37850) #37939

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #33550
pr: #37850
balance segment and balance segment execute at same time, which will cause bounch of corner case.

This PR disable simultaneous balance of segments and channels

…#37850)

issue: milvus-io#33550
balance segment and balance segment execute at same time, which will
cause bounch of corner case.

This PR disable simultaneous balance of segments and channels

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (fc96133) to head (959f2a3).
Report is 10 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/task/scheduler.go 76.31% 6 Missing and 3 partials ⚠️
...ernal/querycoordv2/balance/multi_target_balance.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37939      +/-   ##
==========================================
- Coverage   80.62%   79.67%   -0.95%     
==========================================
  Files        1069     1069              
  Lines      166979   167025      +46     
==========================================
- Hits       134621   133083    -1538     
- Misses      27946    29520    +1574     
- Partials     4412     4422      +10     
Files with missing lines Coverage Δ
internal/querycoordv2/balance/balance.go 94.11% <100.00%> (+0.29%) ⬆️
...erycoordv2/balance/channel_level_score_balancer.go 90.39% <100.00%> (+0.68%) ⬆️
...al/querycoordv2/balance/rowcount_based_balancer.go 95.08% <100.00%> (+0.03%) ⬆️
...ernal/querycoordv2/balance/score_based_balancer.go 98.96% <100.00%> (+1.74%) ⬆️
...ernal/querycoordv2/balance/multi_target_balance.go 83.20% <0.00%> (-0.42%) ⬇️
internal/querycoordv2/task/scheduler.go 90.00% <76.31%> (+1.06%) ⬆️

... and 98 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 25, 2024
@tedxu
Copy link
Contributor

tedxu commented Nov 26, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 93063ce into milvus-io:2.4 Nov 26, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants