Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: set the maximum database configuration to be refreshable #37932

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

pr: #37931

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 22, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (370f39d) to head (a01712d).
Report is 1 commits behind head on 2.4.

Current head a01712d differs from pull request most recent head ccac649

Please upload reports for the commit ccac649 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37932      +/-   ##
==========================================
+ Coverage   72.35%   80.58%   +8.23%     
==========================================
  Files        1070     1069       -1     
  Lines      167353   166979     -374     
==========================================
+ Hits       121084   134557   +13473     
+ Misses      41853    27998   -13855     
- Partials     4416     4424       +8     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <ø> (-0.01%) ⬇️

... and 244 files with indirect coverage changes

---- 🚨 Try these New Features:

@jaime0815 jaime0815 force-pushed the make-max-db-config-refreshable-24 branch from a01712d to ccac649 Compare November 25, 2024 06:20
@mergify mergify bot added the ci-passed label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants