Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ddl and dcl concurrency to avoid competition #37923

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 22, 2024

issue: #37166
pr: #37672

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 22, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 22, 2024
@bigsheeper
Copy link
Contributor

/hold
2.4.18

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (e63a2f3) to head (bfab668).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37923      +/-   ##
==========================================
+ Coverage   79.70%   80.66%   +0.95%     
==========================================
  Files        1069     1069              
  Lines      166979   167005      +26     
==========================================
+ Hits       133092   134708    +1616     
+ Misses      29490    27901    -1589     
+ Partials     4397     4396       -1     
Files with missing lines Coverage Δ
internal/proxy/task_scheduler.go 94.69% <100.00%> (+0.11%) ⬆️
pkg/util/paramtable/component_param.go 98.36% <100.00%> (+<0.01%) ⬆️

... and 102 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants