Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add thread watcher to provide actual thread num (#37905) #37921

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #37905

Related to #37904


@congqixia
Copy link
Contributor Author

wait until 2.4.17 released
/hold

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 22, 2024
@sre-ci-robot sre-ci-robot added do-not-merge/hold area/dependency Pull requests that update a dependency file labels Nov 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 22, 2024
Copy link
Contributor

mergify bot commented Nov 22, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (e63a2f3) to head (528a0f8).
Report is 19 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37921      +/-   ##
==========================================
- Coverage   79.70%   79.65%   -0.06%     
==========================================
  Files        1069     1069              
  Lines      166979   166980       +1     
==========================================
- Hits       133092   133004      -88     
- Misses      29490    29553      +63     
- Partials     4397     4423      +26     
Files with missing lines Coverage Δ
pkg/metrics/info_metrics.go 100.00% <ø> (ø)
pkg/metrics/metrics.go 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 22, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/unhold

@congqixia congqixia added this to the 2.4.18 milestone Nov 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 27, 2024
@sre-ci-robot sre-ci-robot merged commit af4e008 into milvus-io:2.4 Nov 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants