Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx-arm64/native #2

Closed
wants to merge 1 commit into from
Closed

Conversation

kaylumah
Copy link

Add build/lib/Release/arm64/libnfd.dylib

Followed instructions from #1 (comment)

@IceReaper
Copy link

Would it be bloated to also add Linux arm64? :)

@milleniumbug
Copy link
Owner

milleniumbug commented Apr 16, 2023

Not much bloat involved to be honest, especially since users of the library can use appropriate options to not ship libraries for platforms they don't support;

The biggest issue that prevents me from merging this (and also adding support for linux-arm64) is that I have to recompile for every platform involved, as the osx-arm64 uses a newer version of the native library than the other platforms, and this will make for inconsistent behaviour between osx-x64 and osx-arm64.

Ideally this repo should

  • either have a CI/CD setup so it can adapt to potential future changes to the native library
  • or even delegate the responsibility of making shared libraries of the native code upstream

@IceReaper
Copy link

Good point on the CI solution. that would be to prefer. Im basicaly trying to use this library here OpenRA/OpenRA#20789 which is blocked mostly due to the missing natives currently.

@kaylumah
Copy link
Author

Could this be merged if we follow the same instruction on a osx-x64 or is it then still blocked for the diff between Mac and linux/windows?

@milleniumbug
Copy link
Owner

milleniumbug commented Apr 15, 2024

Been neglecting this one for a while, sorry about that.

Yeah, I'll need the osx-x64 version too as I lost my hackintosh virtual machine. I'll try to build Linux and Windows versions next weekend.

@kaylumah
Copy link
Author

No problem at all :)
Unfortunately I no longer have a non-ARM Mac available, so I cannot provide the x64 MacOs binaries myself

@kaylumah kaylumah closed this by deleting the head repository Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants