update to new FB webhook structure. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 21, 2020 14:36
Dimitriy14
reviewed
Oct 29, 2020
| @@ -58,7 +58,7 @@ type GenericMessage struct { | |||
| } | |||
|
|
|||
| type recipient struct { | |||
| ID int64 `json:"id,string"` | |||
| ID string `json:"id,string"` | |||
There was a problem hiding this comment.
I suppose you'd better remove 'string' fom tag.
| @@ -5,55 +5,78 @@ import "fmt" | |||
| // FacebookRequest received from Facebook server on webhook, contains messages, delivery reports and/or postbacks | |||
| type FacebookRequest struct { | |||
| Entry []struct { | |||
| ID int64 `json:"id"` | |||
| ID string `json:"id"` | |||
| Messaging []struct { | |||
There was a problem hiding this comment.
Could you please create Messaging type out of FacebookRequest? I think it should be convenient for others to use Messaging type as an argument in thiers programms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Facebook webhook structure changed. I add some prominent changes such as ID types which are strings now.
I also added support for checking the "is_echo" key in the webhook requests.