Add support for Generic materialized in macro-generated companion object of nested case class
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmytroMitin
changed the title
Generic materialized in companion object of nested case classGeneric materialized in macro-generated companion object of nested case class
DmytroMitin
changed the title
Generic materialized in macro-generated companion object of nested case classGeneric materialized in macro-generated companion object of nested case class
|
Nice thanks. At some point I think I tried to make the constructor default for case classes but it didn't work. I don't remember why exactly. You could try and see which tests fail. I also wonder if we should provide the generic macro annotation as functionality. |
joroKr21
approved these changes
Apr 25, 2024
joroKr21
added a commit
to joroKr21/shapeless
that referenced
this pull request
Apr 25, 2024
…case class (milessabin#1286) Co-authored-by: Georgi Krastev <[email protected]>
joroKr21
added a commit
that referenced
this pull request
Apr 26, 2024
* add explicit type for implicit def (#1330) * Concrete return type for `MkFieldLens.mkFieldLens` (#1324) Co-authored-by: Lior Regev <[email protected]> Co-authored-by: Georgi Krastev <[email protected]> * Add support for `Generic` materialized in companion object of nested case class (#1286) Co-authored-by: Georgi Krastev <[email protected]> --------- Co-authored-by: kenji yoshida <[email protected]> Co-authored-by: Lior Regev <[email protected]> Co-authored-by: Lior Regev <[email protected]> Co-authored-by: Dmytro Mitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #1287