Fix all unit and integration tests. #1194
Conversation
…db issues, but also pass integration tests.
|
As noted I'm pretty sure the changes are required to revive this project, to prepare for future extension, except for the bulkinsert changes for SqlServer. The change is quite invasive there and needs some review form somebody really using bulkinserts. The 'recent' change on identity inserts broke dozens of existing scenario's, but was impossible to work around. The new change unbreaks the scenarios and the old testcases, but may require other users to pass options flags where they didn't have to before. It is quite possible that there are also changes between different SqlServer versions that might be involved. |
|
See also All tests are run against docker versions of the database engine. And a set of nuget packages + nuget packages with debug symbols is produced here. If this is merged this will also enable this for commits to github and for PRs. |
Fix edge case in 'Not' processing, introduced with the other 'not' fix
This issue was caused by a combination of a recent changes to keepIdentity handling and some legacy handling that automatically enables keepIdentity whenever a table has an identity value. As there was no way to override the behavior it was no longer possible to autogenerate identity values, as we (and probably our users) do in many scenarios. This caused > 20 test failures. As there is no easy way to unbreak this I removed the automatically setting keep-identity and cleaned up the arguments to properly allow setting the value as normal Enum (without nullable wrapper). At the same time I introduced ILogger like in the non-bulk api and forwarded that wherever possible (and where I did not forget something). This fixes all the SqlServer Bulkinsert integrationtests.
… testing. Use that for GitHub action. Upgrade packages to versions that have no security reports.
rhuijben
force-pushed
the
fix/all-integration-tests
branch
from
1c025a5 to
38745a4
Compare
These changes are also available as separate PRs, but the combination fixes all the tests and adds testing on GitHub Actions to prove that the changes are fixed and remain fixed.