fix: avoid custom autocmd conflicts with the help popup buffer #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 16.0.0 to 17.0.0. - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@v16.0.0...v17.0.0) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nvim-neorocks/nvim-busted-action](https://github.com/nvim-neorocks/nvim-busted-action) from 1.0.1 to 1.1.0. - [Release notes](https://github.com/nvim-neorocks/nvim-busted-action/releases) - [Changelog](https://github.com/nvim-neorocks/nvim-busted-action/blob/main/CHANGELOG.md) - [Commits](nvim-neorocks/nvim-busted-action@v1.0.1...v1.1.0) --- updated-dependencies: - dependency-name: nvim-neorocks/nvim-busted-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…h 3 updates Bumps the npm-dependencies group with 3 updates in the / directory: [wait-on](https://github.com/jeffbski/wait-on), [express](https://github.com/expressjs/express) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Bumps the npm-dependencies group with 3 updates in the /integration-tests directory: [wait-on](https://github.com/jeffbski/wait-on), [express](https://github.com/expressjs/express) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `wait-on` from 8.0.0 to 8.0.1 - [Release notes](https://github.com/jeffbski/wait-on/releases) - [Commits](jeffbski/wait-on@v8.0.0...v8.0.1) Updates `express` from 4.19.2 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) Updates `vite` from 5.4.3 to 5.4.4 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.4/packages/vite) Updates `wait-on` from 8.0.0 to 8.0.1 - [Release notes](https://github.com/jeffbski/wait-on/releases) - [Commits](jeffbski/wait-on@v8.0.0...v8.0.1) Updates `express` from 4.19.2 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) Updates `vite` from 5.4.3 to 5.4.4 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.4/packages/vite) --- updated-dependencies: - dependency-name: wait-on dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: express dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: wait-on dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: express dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
mikavilpas
force-pushed
the
avoid-autocmd-conflicts-with-help-buffer
branch
from
5281c33
to
e0239ad
Compare
Issue
=====
If the user has set up custom autocmds that trigger for `help` buffers,
the yazi.nvim help popup buffer will be affected by them. I noticed this
after setting the following autocmd:
```lua
vim.api.nvim_create_autocmd("FileType", {
-- always open help buffers in a vertical split
pattern = { "help", "man" },
command = "wincmd L",
})
```
Solution
========
Only use the `syntax` option to set the filetype of the help buffer to
`help`. This way, the user's custom autocmds will not affect the help
popup buffer.
mikavilpas
force-pushed
the
avoid-autocmd-conflicts-with-help-buffer
branch
from
e0239ad
to
c0716a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If the user has set up custom autocmds that trigger for
helpbuffers, the yazi.nvim help popup buffer will be affected by them. I noticed this after setting the following autocmd:Solution
Only use the
syntaxoption to set the filetype of the help buffer tohelp. This way, the user's custom autocmds will not affect the help popup buffer.