Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: ignore pygrio default int32 type #626

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Jun 29, 2024

Fixes the test failures.
Geopandas reached 1.0.0 🎉 (hopefully things stabilize now...)
With that Geopandas defaults to pyogrio instead of fiona. Apparently pygrio reads integers as i32 if they are small enough and that differentiates to the pd.read_csv which always reads them as i64.
As this behavior is understandable, I choosed to ignore the errors.

@bifbof bifbof requested a review from hongyeehh June 29, 2024 19:48
@bifbof bifbof mentioned this pull request Jun 29, 2024
@hongyeehh
Copy link
Member

thanks for the fix, merging now

@hongyeehh hongyeehh merged commit 3308ef9 into mie-lab:master Jun 30, 2024
6 checks passed
@bifbof bifbof deleted the i32 branch September 3, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants