Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: enable subclassing for tours #530

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Sep 18, 2023

The last class. For reference see #490.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (296f397) 93.31% compared to head (3923d12) 93.44%.

❗ Current head 3923d12 differs from pull request most recent head 2656087. Consider uploading reports for the commit 2656087 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   93.31%   93.44%   +0.13%     
==========================================
  Files          34       34              
  Lines        2153     2166      +13     
  Branches      409      414       +5     
==========================================
+ Hits         2009     2024      +15     
+ Misses        130      129       -1     
+ Partials       14       13       -1     
Files Changed Coverage Δ
trackintel/__init__.py 100.00% <100.00%> (ø)
trackintel/io/file.py 100.00% <100.00%> (ø)
trackintel/io/postgis.py 96.07% <100.00%> (ø)
trackintel/model/__init__.py 100.00% <100.00%> (ø)
trackintel/model/tours.py 100.00% <100.00%> (+10.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hongyeehh hongyeehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from my side, just one small docstring question.

trackintel/model/tours.py Show resolved Hide resolved
@hongyeehh hongyeehh merged commit 0f8030c into mie-lab:master Sep 19, 2023
5 checks passed
@bifbof bifbof deleted the tours_to_class branch September 19, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants