Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: remove unnecessary assert statements from tests #499

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Aug 1, 2023

In #498 I copied assert locs.as_locations from another test. But we decided in #215 to use locs.as_locations to check validity.
To never copy the old style again, this PR removes all of it from the tests (and in addition I removed some assert True).
As a sidenote, I think some validity checks don`t work, as discussed in #476, but most are fine.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (07b201a) 92.37% compared to head (c972fc0) 92.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files          39       39           
  Lines        2019     2019           
  Branches      344      344           
=======================================
  Hits         1865     1865           
  Misses        133      133           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hongyeehh hongyeehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging!

@hongyeehh hongyeehh merged commit 6bf010c into mie-lab:master Aug 2, 2023
7 checks passed
@bifbof bifbof deleted the rem_asserts branch August 2, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants