This repository was archived by the owner on Aug 25, 2021. It is now read-only.
Open
Conversation
Collaborator
noscripter
commented
Jun 26, 2019
noscripter
commented
- refactor: remove dead code
- refactor: fix Ineffective parameter type
noscripter
force-pushed
the
refactor_20190625
branch
from
f293ab7 to
ba7a480
Compare
mariodu
suggested changes
Jun 27, 2019
| } else if (url && url instanceof URL) { | ||
| _url = urlToOptions(url); | ||
| } else { | ||
| _options = url; |
Collaborator
Author
There was a problem hiding this comment.
Variable _options with null and undefined have the same effect for the following statement, so it's better to be removed. Just my 2 cents, up to your judgement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.