Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package bullmq #4257

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: add package bullmq #4257

merged 2 commits into from
Jan 6, 2025

Conversation

harperKKK
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • 任务队列支持使用 bullmq 来支持更多新的队列 api,参数基本与 midwayjs/bull 一致
  • 有改写 bull-board 来支持前端显示队列状态,但因为没有 pacakge 写不了依赖,没有提在这个 pr

packages/bullmq/src/config/config.default.ts Outdated Show resolved Hide resolved
packages/bullmq/src/config/config.default.ts Outdated Show resolved Hide resolved
packages/bullmq/src/framework.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.42157% with 35 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (a3ca53b) to head (8a5d42d).
Report is 529 commits behind head on main.

Files with missing lines Patch % Lines
packages/bullmq/src/framework.ts 90.41% 23 Missing ⚠️
packages/bullmq/src/configuration.ts 84.09% 7 Missing ⚠️
packages/bullmq/src/decorator.ts 91.52% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
+ Coverage   84.55%   85.28%   +0.73%     
==========================================
  Files         491      526      +35     
  Lines       46778    50543    +3765     
  Branches     5601     5850     +249     
==========================================
+ Hits        39551    43106    +3555     
- Misses       7191     7411     +220     
+ Partials       36       26      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import { BULLMQ_PROCESSOR_KEY, BULLMQ_QUEUE_KEY } from './constants';
import { JobsOptions } from 'bullmq';

export function Processor(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接用 Worker 的概念好了,Processor在 bullmq里已经没有了。

@czy88840616 czy88840616 added pr: new feature This PR adds a new API or behavior. pr: polish This PR adds a very minor behavior improvement that users will enjoy. and removed pr: new feature This PR adds a new API or behavior. labels Jan 6, 2025
@czy88840616 czy88840616 changed the title feat: package bullmq feat: add package bullmq Jan 6, 2025
@czy88840616 czy88840616 merged commit ddceb32 into midwayjs:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

3 participants