Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wakatime.DesktopWakatime version 0.1.0 #185437

Conversation

KarbitsCode
Copy link
Contributor

@KarbitsCode KarbitsCode commented Oct 24, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 24, 2024
@stephengillie
Copy link
Collaborator

Hi @KarbitsCode,

Manual Validation ended with:
image
Both the desktop shortcut and double-clicking the EXE directly gave this error.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Oct 24, 2024
@KarbitsCode
Copy link
Contributor Author

Both the desktop shortcut and double-clicking the EXE directly gave this error.

Comfirmed I can reproduce the error with Windows Sandbox:

Screenshot 2024-10-25 085417

But I can't reproduce that in my host machine, which is why I missed it.
I will investigate this error.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 25, 2024
@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Oct 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Moderator-Approved One of the Moderators has reviewed and approved this PR and removed No-Recent-Activity No activity has occurred on this work item for seven days. labels Oct 31, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Oct 31, 2024
@ItzLevvie
Copy link
Contributor

[Policy] Reset Labels

@ItzLevvie
Copy link
Contributor

[Policy] Needs-Author-Feedback

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. and removed Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. labels Oct 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 3, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Nov 4, 2024
@stephengillie stephengillie removed the Needs-Author-Feedback This needs a response from the author. label Nov 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 39a1ddd into microsoft:master Nov 6, 2024
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@KarbitsCode
Copy link
Contributor Author

KarbitsCode commented Nov 6, 2024

Hi @stephengillie,
Why is this got approved?

@stephengillie
Copy link
Collaborator

I kept seeing this PR an a "squash-ready" state and merged it along with other PRs in this state. I have been moving too fast, trying to do too much, and mistakes like this are becoming more frequent.

@KarbitsCode KarbitsCode deleted the Wakatime.DesktopWakatime-0.1.0-a4f70ec2-e4eb-4a6b-8406-5b5dd18ed389 branch November 7, 2024 06:38
@KarbitsCode
Copy link
Contributor Author

KarbitsCode commented Nov 7, 2024

I kept seeing this PR an a "squash-ready" state and merged it along with other PRs in this state. I have been moving too fast, trying to do too much, and mistakes like this are becoming more frequent.

It's okay, after all the problem only occurs in sandboxed environment anyway.
I have created an issue on their repo (wakatime/desktop-wakatime#70), but there is no response yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants