fix: memory leak in pane composite bar #282589
Open
+19
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in
paneCompositeBar.It seems the
paneCompositeBarcan be visible for a longer period of time, while it's actions can update many times.By changing the code to use a
DisposableMap, it ensures that the previous actions are disposed when the actions are updated.Before
When renaming a variable 97 times with refactor preview, it seems 3 actions are created each time:
After
When renaming a variable 97 times with refactor preview, no more action leaks are detected: