fix: reposition webview overlay on workbench scroll #282555
Open
+15
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #282039
When the VS Code window is shrunk to a small size, a horizontal scrollbar appears in the workbench grid. Scrolling this scrollbar caused the webview overlay (e.g., Release Notes) to remain "stuck" in place while the rest of the UI scrolled.
Root Cause
The
WebviewEditoronly listened topart.onDidScrollevents from the editor part's grid. However, when the window is very small, the scroll happens at the workbench grid level (parent of the editor part), which wasn't being captured.Solution
Added a scroll event listener on the main workbench container with
capture: trueto catch scroll events from any child element, including the workbench grid's split view. This ensures the webview overlay is repositioned whenever any scroll occurs in the workbench.Testing
Checklist