Fix bug that blocks sending extension error telemetry #282549
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrivMS
approved these changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug that blocked extension error telemetry from being sent correctly. The issue was that when telemetry data wasn't provided to logging methods, the default empty object {} didn't match the expected ExtHostTelemetryEventData structure, potentially causing downstream telemetry senders to fail. The fix ensures the structured format with properties and measurements fields is used by default.
Key Changes
- Updated default telemetry data structure from
{}to{ properties: {}, measurements: {} }to matchExtHostTelemetryEventDatatype - Changed trace event name from 'exception' to 'unhandlederror' for better semantic accuracy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282550