Adjust gutter padding and icon alignment in InlineEditsGutterIndicator #282508
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the gutter padding and icon alignment in the InlineEditsGutterIndicator to improve layout consistency and visual appearance. The primary changes involve splitting a single padding value into separate left and top padding values for more precise control, and dynamically adjusting icon alignment based on the layout direction.
- Split unified gutter viewport padding into separate left (1px) and top (2px) padding values
- Updated icon alignment to use
flex-startwhen icon direction is 'bottom' (icon points down), otherwiseflex-end - Adjusted all padding-dependent calculations to use the appropriate padding value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the gutter padding and icon alignment in the InlineEditsGutterIndicator to improve layout consistency and visual appearance. Adjustments include modifying padding values and aligning icons based on the layout direction. Testing can be done by reviewing the inline edit indicators in the editor for proper alignment and spacing.
Addresses: #281477