disable corepack auto pin feature when executing npm view #210601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankli0324
changed the title
frankli0324
changed the title
meganrogge
previously approved these changes
Apr 17, 2024
auto-merge was automatically disabled
April 17, 2024 23:27
Head branch was pushed to by a user without write access
TylerLeonhardt
approved these changes
Apr 18, 2024
meganrogge
approved these changes
Apr 18, 2024
|
is there any solution to disable this till the fix is released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210556
the bundled plugin "npm" attempts to fetch the package versions with command "npm view --json" each time a user hovers on a package in package.json.
https://github.com/microsoft/vscode/blob/main/extensions/npm/src/features/packageJSONContribution.ts#L286-L290
however with a corepack installation (e.g. brew install corepack), the default behavior of the wrapped npm binary would try to pin the current package manager version to the package.json of the current project.
It's surprising behavior, since the action is triggered by vscode, and no obvious way to find out what's behind the vscode action, disabling the feature entirely would be reasonable since npm extension only wants the package information