This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Updated some Debian scripts to support arm #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's actually a branch with all the scripts updated to support this along with more secure use of GPG keys for apt. I'm waiting on a M1 mac to arrive to allow me to test, but if you want to help verify, it is here: https://github.com/microsoft/vscode-dev-containers/tree/clantz/apt-key-and-architecture |
|
@Chuxel I had missed that :) Looks like it already includes everything I did in this PR and then more. Closing this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some (not all) scripts in script-library to add fixes so they can be used to build arm64 containers too. Note that the PR doesn't add full arm64 support for the repo (see #558), but it does offer some help in that direction.
How this came to be: I wanted to be able to use a devcontainer on a M1 Mac. The base images that we currently publish don't support ARM, so I resorted to creating my own containers but I used the scripts in the script-library folder to make things easier for me.