Update build system to use buildx, support multi-arch builds #1018
Conversation
| } else { | ||
| await asyncUtils.spawn('docker', ['buildx', 'use', 'vscode-dev-containers']); | ||
| } | ||
| await asyncUtils.spawn('docker', ['run', '--privileged', '--rm', 'tonistiigi/binfmt', '--install', 'all']); |
There was a problem hiding this comment.
No idea what this line is doing :D . Maybe add a comment to make it more clear?
There was a problem hiding this comment.
Sure - it sets up QEMU to enable multi-platform builds. Docker Desktop does htis as a part of install so people don't know. Will add a comment.
| case 'aarch32': localArchitecture = 'linux/arm/v7'; break; | ||
| case 'aarch64': localArchitecture = 'linux/arm64'; break; | ||
| case 'x64': localArchitecture = 'linux/amd64'; break; | ||
| case 'x32': localArchitecture = 'linux/386'; break; |
There was a problem hiding this comment.
is this supposed to be linux/i386? Doesn't look right to me without the i for some reason, but I might just be wrong
There was a problem hiding this comment.
Yeah for Docker it's w/o the i. Type docker buildx ls locally to see architectures that are setup to emulate. Desktop has them all installed.
|
@joshspicer Triggered dev builds and they all successfully ran. The codespaces-linux image will now be built using buildx which should help reduce total layers. |
Implements #914.
This PR does not update config to start building linux/arm64, but rather sets up the build system to do so. See #558 (comment) for issues preventing switch, current plan of action.