Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended remote support #9569

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Extended remote support #9569

merged 6 commits into from
Jul 19, 2022

Conversation

xisui-MSFT
Copy link
Contributor

Extended remote support #9491 #9505 #8497 #9195
Also show process picker automatically when the process ID is not provided in launch.json

@xisui-MSFT
Copy link
Contributor Author

Forgot to run linter...

@sean-mcmanus
Copy link
Contributor

What release is this for?

@xisui-MSFT
Copy link
Contributor Author

What release is this for?

Extended remote was added to MIEngine several months ago: microsoft/MIEngine#1260, and this doesn't have any other dependencies. So ideally we would like to target the earliest release we can achieve.

@sean-mcmanus sean-mcmanus added this to the 1.11.3 milestone Jul 11, 2022
Extension/src/Debugger/attachToProcess.ts Outdated Show resolved Hide resolved
@Colengms
Copy link
Contributor

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

@xisui-MSFT
Copy link
Contributor Author

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

Can you give an example? I saw formats like {0}, so all relevant strings in this PR uses this format.

@sean-mcmanus
Copy link
Contributor

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

Can you give an example? I saw formats like {0}, so all relevant strings in this PR uses this format.

In https://github.com/microsoft/vscode-cpptools/blob/main/Extension/package.nls.json .

@sean-mcmanus
Copy link
Contributor

@xisui-MSFT Is this going to be checked in? We're planning to release 1.11.3 on Monday. Does the changelog need to be updated?

@sean-mcmanus sean-mcmanus merged commit f38f551 into main Jul 19, 2022
@sean-mcmanus sean-mcmanus deleted the dev/xisui/extended_remote branch July 19, 2022 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants