Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cpp Context Traits to Completions Prompt #12821

Conversation

kuchungmsft
Copy link
Contributor

@kuchungmsft kuchungmsft commented Oct 8, 2024

  • Move related files code to its own module
  • Refactor related files provider code to enable unit testing
  • Add Cpp context traits to completions prompt

image

@sean-mcmanus
Copy link
Contributor

@kuchungmsft What release is this for? 1.23.0?

@kuchungmsft
Copy link
Contributor Author

@kuchungmsft What release is this for? 1.23.0?

@benmcmorran can you please comment?

@bobbrow
Copy link
Member

bobbrow commented Oct 9, 2024

@kuchungmsft What release is this for? 1.23.0?

We're not taking any more changes into 1.22, so this will need to wait until 1.23.0

@bobbrow bobbrow added this to the 1.23 milestone Oct 9, 2024
@kuchungmsft kuchungmsft force-pushed the kuchung/ProvideCppContextToCompletionPrompts branch 2 times, most recently from c65cb36 to 08923db Compare October 9, 2024 23:52
@kuchungmsft kuchungmsft force-pushed the kuchung/ProvideCppContextToCompletionPrompts branch 3 times, most recently from 44a9f0d to 19583ac Compare October 11, 2024 01:07
- Move related files code to its own module
- Refactor related files provider code to enable unit testing
- Add Cpp context traits to completions prompt
@kuchungmsft kuchungmsft force-pushed the kuchung/ProvideCppContextToCompletionPrompts branch from 19583ac to 1cfa904 Compare October 11, 2024 01:20
@benmcmorran benmcmorran merged commit 05c9176 into microsoft:main Oct 14, 2024
6 checks passed
@kuchungmsft kuchungmsft deleted the kuchung/ProvideCppContextToCompletionPrompts branch October 14, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants