Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse workflow for CI builds #11503

Merged
merged 17 commits into from
Oct 12, 2023
Merged

Reuse workflow for CI builds #11503

merged 17 commits into from
Oct 12, 2023

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Oct 4, 2023

Note on Xvfb: GabrielBB/[email protected] is deprecated, it suggests to use coactions/setup-xvfb@v1. Another example to start https://github.com/microsoft/vscode-test/blob/master/sample/azure-pipelines.yml.

@michelleangela michelleangela marked this pull request as ready for review October 4, 2023 20:18
working-directory: Extension

- name: Compile Sources
run: yarn run compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy Are these still the correct command lines to use when building in the lab?

sean-mcmanus
sean-mcmanus previously approved these changes Oct 4, 2023
@michelleangela michelleangela merged commit 74bddb8 into main Oct 12, 2023
@michelleangela michelleangela deleted the dev/mimatias/yml branch October 12, 2023 01:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants