Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update localized intellisense crash string #11356

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Update localized intellisense crash string #11356

merged 9 commits into from
Sep 13, 2023

Conversation

browntarik
Copy link
Contributor

No description provided.

@browntarik browntarik changed the title update localized intellisense crash string Update localized intellisense crash string Aug 23, 2023
bobbrow
bobbrow previously approved these changes Aug 23, 2023
View reviewed changes
@browntarik browntarik enabled auto-merge (squash) August 24, 2023 22:00
@browntarik browntarik disabled auto-merge August 24, 2023 22:24
sean-mcmanus
sean-mcmanus requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the . and : can't be in the {0} because I just realized that they're translated differently, i.e. they need to be part of the loc string -- can you just create 2 strings, one that ends with : {0} and one that ends with . (the original)?

sean-mcmanus
sean-mcmanus requested changes Aug 30, 2023
View reviewed changes
Extension/src/nativeStrings.json Outdated Show resolved Hide resolved
michelleangela
michelleangela previously approved these changes Sep 7, 2023
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Sep 8, 2023
View reviewed changes
Extension/src/nativeStrings.json Outdated Show resolved Hide resolved
@browntarik browntarik merged commit c5c64ad into main Sep 13, 2023
4 checks passed
@browntarik browntarik deleted the browntarik/crashTelemetry branch September 13, 2023 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow left review comments

@michelleangela michelleangela michelleangela approved these changes

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@browntarik @bobbrow @sean-mcmanus @michelleangela