Merge pull request #7480 from microsoft/seanmcm/1_4_0_insiders

1.4.0-insiders

.github/ISSUE_TEMPLATE/debugger.md

@@ -1,30 +1,30 @@
 ---
-name: Debugger
-about: Issues pertaining to debugging such as call stack, breakpoints, watch window,
+name: Bug Report - Debugger
+about: Create a bug report for debugging such as call stack, breakpoints, watch window,
   launching or attaching to a debuggee.
 title: ''
 labels: ''
 assignees: ''
 
 ---
 
-Type: Debugger
-<!----- Input information below ----->
+Bug type: Debugger
 
-<!--
-**Prior to filing an issue, please review:**
-- Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
-- Our documentation at https://code.visualstudio.com/docs/languages/cpp
-- FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
+<!-- Prior to creating a bug report, please review:
+📝 Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
+📜 Our documentation at https://code.visualstudio.com/docs/languages/cpp
+📙 FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
 -->
 
+
 **Describe the bug**
 - OS and Version:
 - VS Code Version:
 - C/C++ Extension Version:
 - Other extensions you installed (and if the issue persists after disabling them):
 - A clear and concise description of what the bug is.
 
+
 **To Reproduce**
 *Please include a code sample and `launch.json` configuration.*
 Steps to reproduce the behavior:
@@ -33,6 +33,7 @@ Steps to reproduce the behavior:
 3. Scroll down to '....'
 4. See error
 
+
 **Additional context**
 *If applicable, please include logging by adding "logging": { "engineLogging": true, "trace": true, "traceResponse": true } in your `launch.json`*
 Add any other context about the problem here including log or error messages in your Debug Console or Output windows.

.github/ISSUE_TEMPLATE/feature-request.md

@@ -0,0 +1,17 @@
+---
+name: Feature Request
+about: Suggest an idea for this extension.
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+Type: Feature Request
+
+<!-- Prior to creating a feature request, please review
+existing issues at https://github.com/Microsoft/vscode-cpptools/issues
+to avoid creating duplicates.
+-->
+
+<!-- Describe the feature you'd like. -->

.github/ISSUE_TEMPLATE/general-extension.md

@@ -1,29 +1,29 @@
 ---
-name: General Extension
-about: Issues pertaining to downloading, installing, or building the extension.
+name: Bug Report - General Extension
+about: Create a bug report for downloading, installing, or building the extension.
 title: ''
 labels: ''
 assignees: ''
 
 ---
 
-Type: General
-<!----- Input information below ----->
+Bug type: General
 
-<!--
-**Prior to filing an issue, please review:**
-- Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
-- Our documentation at https://code.visualstudio.com/docs/languages/cpp
-- FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
+<!-- Prior to creating a bug report, please review:
+📝 Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
+📜 Our documentation at https://code.visualstudio.com/docs/languages/cpp
+📙 FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
 -->
 
+
 **Describe the bug**
 - OS and Version:
 - VS Code Version:
 - C/C++ Extension Version:
 - Other extensions you installed (and if the issue persists after disabling them):
 - A clear and concise description of what the bug is.
 
+
 **To Reproduce**
 *Please include code sample and `task.json` files.*
 Steps to reproduce the behavior:
@@ -32,11 +32,14 @@ Steps to reproduce the behavior:
 3. Scroll down to '....'
 4. See error
 
+
 **Expected behavior**
-A clear and concise description of what you expected to happen.
+<!-- A clear and concise description of what you expected to happen. -->
+
 
 **Screenshots**
-If applicable, add screenshots to help explain your problem.
+<!-- If applicable, add screenshots to help explain your problem. -->
+
 
 **Additional context**
-Add any other context about the problem here including log messages from the Output window.
+<!-- Add any other context about the problem here including log messages from the Output window. -->

.github/ISSUE_TEMPLATE/language-service.md

@@ -1,58 +1,65 @@
 ---
-name: Language Service
-about: 'Issues pertaining to IntelliSense, autocomplete, code editing, etc. '
+name: Bug Report - Language Service
+about: 'Create a bug report for IntelliSense, autocomplete, code editing, code navigation, etc.'
 title: ''
 labels: ''
 assignees: ''
 
 ---
 
-**Type: LanguageService**
-<!----- Input information below ----->
+Bug type: Language Service
 
-<!--
-**Prior to filing an issue, please review:**
-- Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
-- Our documentation at https://code.visualstudio.com/docs/languages/cpp
-- FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
+<!-- Prior to creating a bug report, please review:
+📝 Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
+📜 Our documentation at https://code.visualstudio.com/docs/languages/cpp
+📙 FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp
 -->
 
+
 **Describe the bug**
 - OS and Version:
 - VS Code Version:
 - C/C++ Extension Version:
 - Other extensions you installed (and if the issue persists after disabling them):
-- Does this issue involve using SSH remote to run the extension on a remote machine?:
+- If using SSH remote, specify OS of remote machine:
 - A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).
 
+
 **Steps to reproduce**
-<!-- Provide clear steps to reproduce the behavior: -->
-<!-- *The most actionable issue reports include a code sample including configuration files such as c_cpp_properties.json* -->
+<!-- Provide clear steps to reproduce the bug: -->
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
 4. See error
 
+
 **Expected behavior**
 <!-- A clear and concise description of what you expected to happen. -->
 
-<!-- Please provide the following logs that show diagnostics and debugging information about the language server.
-1. Logs from the command `C/C++: Log Diagnostics`
-2. Logs from [the language server](https://code.visualstudio.com/docs/cpp/enable-logging-cpp#_enable-logging-for-the-language-server)
- -->
-<details>
-  <summary><strong>Logs</strong></summary>
 
-<!-- Note: do not remove empty line after </summary> tag, otherwise the code blocks formatting won't show correctly. -->
-```
-Insert logs here.
-```
-</details>
+**Code sample and logs**
+<!-- Please provide code sample, your c_cpp_properties.json and logs. -->
+- Code sample
+
+- Configurations in `c_cpp_properties.json`
+
+- Logs from running `C/C++: Log Diagnostics` from the VS Code command palette
+
+- Logs from [the language server logging](https://code.visualstudio.com/docs/cpp/enable-logging-cpp#_enable-logging-for-the-language-server)
+
 
 **Screenshots**
 <!-- If applicable, add screenshots to help explain your problem. -->
 
+
 **Additional context**
 <!--
-* Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "https://msdl.microsoft.com/download/symbols".
+Providing call stacks:
+For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "https://msdl.microsoft.com/download/symbols".
+
+Instructions for attaching debugger to language service process:
+https://github.com/microsoft/vscode-cpptools/wiki/Attaching-debugger-to-cpptools-or-cpptools%E2%80%90srv.
+
+Performance analysis:
+For a performance issue see instructions at https://github.com/microsoft/vscode-cpptools/wiki/Troubleshooting-Performance-Issues.
 -->

.github/workflows/ci_mac.yml

@@ -19,7 +19,7 @@ jobs:
           node-version: 14.16.x
 
       - name: Install Dependencies
-        run: yarn install
+        run: yarn install --network-timeout 100000
         working-directory: Extension
 
       - name: Generate hashes for runtime dependency packages

.github/workflows/enhancement-closer-no-milestone.yml

@@ -0,0 +1,30 @@
+name: Enhancement Closer (no milestone)
+on:
+  schedule:
+    - cron: 50 11 * * * # Run at 11:50 AM UTC (3:50 AM PST, 4:50 AM PDT)
+  workflow_dispatch:
+   inputs:
+     readonly:
+       description: "readonly: Specify true or 1 to prevent changes from being commited to GitHub"
+       default: false
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Actions
+        uses: actions/checkout@v2
+      - name: Install Actions
+        run: cd ./.github/actions && npm install --production && cd ../..
+      - name: Stale Closer
+        uses: ./.github/actions/StaleCloser
+        with:
+          readonly: ${{ github.event.inputs.readonly }}
+          labels: enhancement
+          ignoreLabels: debugger,internal,Feature Request
+          addLabels: more votes needed
+          closeDays: 60
+          maximumVotes: 2
+          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          setMilestoneId: 30
+          ignoreMilestoneNames: "*"

.github/workflows/enhancement-closer-triage.yml

@@ -0,0 +1,30 @@
+name: Enhancement Closer (Triage)
+on:
+  schedule:
+    - cron: 40 11 * * * # Run at 11:40 AM UTC (3:40 AM PST, 4:40 AM PDT)
+  workflow_dispatch:
+   inputs:
+     readonly:
+       description: "readonly: Specify true or 1 to prevent changes from being commited to GitHub"
+       default: false
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Actions
+        uses: actions/checkout@v2
+      - name: Install Actions
+        run: cd ./.github/actions && npm install --production && cd ../..
+      - name: Stale Closer
+        uses: ./.github/actions/StaleCloser
+        with:
+          readonly: ${{ github.event.inputs.readonly }}
+          labels: enhancement
+          ignoreLabels: debugger,internal,Feature Request
+          addLabels: more votes needed
+          closeDays: 60
+          maximumVotes: 2
+          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          milestoneName: Triage
+          milestoneId: 30

.github/workflows/enhancement-reopener.yml

@@ -0,0 +1,31 @@
+name: Enhancement Reopener
+on:
+  schedule:
+    - cron: 20 12 * * * # Run at 12:20 PM UTC (4:20 AM PST, 5:20 AM PDT)
+  workflow_dispatch:
+   inputs:
+     readonly:
+       description: "readonly: Specify true or 1 to prevent changes from being commited to GitHub"
+       default: false
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Actions
+        uses: actions/checkout@v2
+      - name: Install Actions
+        run: cd ./.github/actions && npm install --production && cd ../..
+      - name: Run Reopener
+        uses: ./.github/actions/Reopener
+        with:
+          readonly: ${{ github.event.inputs.readonly }}
+          alsoApplyToOpenIssues: true
+          reopenComment: This feature request has received enough votes to be added to our backlog.
+          labels: enhancement
+          minimumVotes: 3
+          ignoreLabels: debugger,internal,Feature Request
+          milestoneId: 30
+          milestoneName: Triage
+          setMilestoneId: 28
+          removeLabels: more votes needed

Build/loc/LocProject.json

@@ -0,0 +1,13 @@
+{
+    "Projects": [
+        {
+            "LanguangeSet": "VS_Main_Languages",
+            "LocItems": [
+                {
+                    "SourceFile": "vscode-extensions-localization-export\\vscode-extensions\\vscode-cpptools.xlf",
+                    "Languages": "cs;de;es;fr;it;ja;ko;pl;pt-BR;ru;tr;zh-Hans;zh-Hant"
+                }
+            ]
+        }
+    ]
+}

Build/loc/TranslationsExport.yml

@@ -0,0 +1,37 @@
+# ==================================================================================
+# Pipeline for VsCodeExtension-Localization build definition
+# Runs OneLocBuild task to localize xlf file
+# ==================================================================================
+
+resources:
+  repositories:
+  - repository: self
+    clean: true
+
+trigger: none
+pr: none
+
+pool:
+  vmImage: 'windows-latest'
+
+steps:
+- task: CmdLine@2
+  inputs:
+    script: 'cd ./Extension && yarn run translations-export && cd ..'
+
+- task: OneLocBuild@1
+  env:
+    SYSTEM_ACCESSTOKEN: $(System.AccessToken)
+  inputs:
+    locProj: 'Build/loc/LocProject.json'
+    outDir: '$(Build.ArtifactStagingDirectory)'
+    isCreatePrSelected: false
+    prSourceBranchPrefix: 'locfiles'
+    packageSourceAuth: 'patAuth'
+    patVariable: '$(OneLocBuildPat)'
+
+- task: PublishBuildArtifacts@1
+  inputs:
+    PathtoPublish: '$(Build.ArtifactStagingDirectory)'
+    ArtifactName: 'drop'
+    publishLocation: 'Container'