Merge pull request #2749 from Microsoft/seanmcm/0_20_1_release

Seanmcm/0 20 1 release

Code Samples/Fib/.vscode/tasks.json

@@ -4,7 +4,7 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "taskName": "build",
+            "label": "build",
             "type": "shell",
             "group": {
                 "kind": "build",
@@ -47,4 +47,4 @@
             }
         }
     ]
-}
+}

Extension/CHANGELOG.md

@@ -1,6 +1,12 @@
 # C/C++ for Visual Studio Code Change Log
 
-## Version 0.20.0: October 29, 2018
+## Version 0.20.1: October 31, 2018
+* Fix IntelliSense-based `Go to Declaration` when there's only a definition in a TU. [#2743](https://github.com/Microsoft/vscode-cpptools/issues/2743)
+* Fix `#include` completion for standalone header files. [#2744](https://github.com/Microsoft/vscode-cpptools/issues/2744)
+* Fix the highest hitting main process crash.
+* Fix IntelliSense process crash with completion.
+
+## Version 0.20.0: October 30, 2018
 * Add IntegratedTerminal support for Linux and Windows. [#35](https://github.com/microsoft/vscode-cpptools/issues/35)
 * Unify Visual Studio Code debug protocol parsing by using a shared library with Visual Studio.
 * Fix IntelliSense-based `Go to Definition` on overloads (in the same TU). [#1071](https://github.com/Microsoft/vscode-cpptools/issues/1071)
@@ -73,7 +79,7 @@
 * Fix IntelliSense crash when the gcc-8 type_traits header is used. [#2323](https://github.com/Microsoft/vscode-cpptools/issues/2323), [#2328](https://github.com/Microsoft/vscode-cpptools/issues/2328)
 * Limit configuration popups to one at a time. [#2324](https://github.com/Microsoft/vscode-cpptools/issues/2324)
 * Don't show `includePath` code actions if compile commands or custom configuration providers are used. [#2334](https://github.com/Microsoft/vscode-cpptools/issues/2334)
-* Fix `Cpp.clang_format_path` not accepting environment variables. [#2344](https://github.com/Microsoft/vscode-cpptools/issues/2344)
+* Fix `C_Cpp.clang_format_path` not accepting environment variables. [#2344](https://github.com/Microsoft/vscode-cpptools/issues/2344)
 * Fix IntelliSense not working with non-ASCII characters in the WSL install path. [#2351](https://github.com/Microsoft/vscode-cpptools/issues/2351)
 * Filter out buggy IntelliSense error `"= delete" can only appear on the first declaration of a function`. [#2352](https://github.com/Microsoft/vscode-cpptools/issues/2352)
 * Fix IntelliSense failing with WSL if gcc is installed bug g++ isn't. [#2360](https://github.com/Microsoft/vscode-cpptools/issues/2360)

Extension/package.json

@@ -2,7 +2,7 @@
   "name": "cpptools",
   "displayName": "C/C++",
   "description": "C/C++ IntelliSense, debugging, and code browsing.",
-  "version": "0.20.0",
+  "version": "0.20.1",
   "publisher": "ms-vscode",
   "preview": true,
   "icon": "LanguageCCPP_color_128x.png",
@@ -1411,14 +1411,14 @@
     "vscode-cpptools": "2.1.1",
     "vscode-debugadapter": "~1.24.0",
     "vscode-debugprotocol": "~1.24.0",
-    "vscode-extension-telemetry": "~0.1.0",
+    "vscode-extension-telemetry": "~0.0.22",
     "vscode-languageclient": "3.5.1",
     "yauzl": "~2.8.0"
   },
   "runtimeDependencies": [
     {
       "description": "C/C++ language components (Linux / x86_64)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2026727",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2036673",
       "platforms": [
         "linux"
       ],
@@ -1432,7 +1432,7 @@
     },
     {
       "description": "C/C++ language components (Linux / x86)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2026568",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2036672",
       "platforms": [
         "linux"
       ],
@@ -1448,7 +1448,7 @@
     },
     {
       "description": "C/C++ language components (OS X)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2026569",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2036674",
       "platforms": [
         "darwin"
       ],
@@ -1459,7 +1459,7 @@
     },
     {
       "description": "C/C++ language components (Windows)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2026728",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2036671",
       "platforms": [
         "win32"
       ],

Extension/src/LanguageServer/extension.ts

@@ -661,8 +661,8 @@ function handleCrashFileRead(err: NodeJS.ErrnoException, data: string): void {
         endCrash = data.length - 1;
     }
     data = data.substr(startCrash, endCrash - startCrash);
-    if (data.length > 16384) {
-        data = data.substr(0, 16384) + "...";
+    if (data.length > 8192) { // The API has an 8k limit.
+        data = data.substr(0, 8189) + "...";
     }
     if (data.length < 2) {
         return; // Don't send telemetry if there's no call stack.

launch.md

@@ -2,27 +2,29 @@
 
 The **launch.json** file is used to configure the debugger in Visual Studio Code.
 
-Visual Studio Code generates a **launch.json** with almost all of the required information.  To get started
+Visual Studio Code generates a **launch.json** with almost all of the required information. To get started
 debugging you need to fill in the `program` field with the path to the executable you plan to debug. This must be specified for
 both the launch and attach (if you plan to attach to a running instance at any point) configurations.
 
-The generated file contains two sections.  One that configures debugging for launch and a second that configures debugging for attach.
+The generated file contains two sections. One that configures debugging for launch and a second that configures debugging for attach.
 
 # Configure VS Code's debugging behavior
 
-Set or change the following options to control VS Code's behavior during debugging
+Set or change the following options to control VS Code's behavior during debugging:
 
 * #### `program` (required)
   Specifies the full path to executable the debugger will launch or attach to.
 
 * #### `symbolSearchPath`
-  Tells the _Visual Studio Windows Debugger_ what paths to search for symbol (.pdb) files.  Separate multiple paths with a semicolon. Example `"C:\\Symbols;C:\\SymbolDir2"`
+  Tells the _Visual Studio Windows Debugger_ what paths to search for symbol (.pdb) files. Separate multiple paths with a semicolon. Example `"C:\\Symbols;C:\\SymbolDir2"`.
 
 * #### `additionalSOLibSearchPath`
   Tells _GDB or LLDB_ what paths to search for .so files. Separate multiple paths with a semicolon. Example: `"/Users/user/dir1;/Users/user/dir2"`.
 
 * #### `externalConsole`
-  If set to `true`, launches an external console for the application. If `false`, no console is launched and VS Code's debugging console is used. Note this option is ignored in some cases for technical reasons.
+  Windows: When set to true, it will spawn an external console. When set to false, it will use VS Code's integratedTerminal.
+  Linux: When set to true, it will notify VS Code to spawn an external console. When set to false, it will use VS Code's integratedTerminal.
+  macOS: When set to true, it will spawn an external console through `lldb-mi`. When set to false, the output can be seen in VS Code's debugConsole. Due to limitations within `lldb-mi`, integratedTerminal support is not available.
 
 * #### `logging`
   Optional flags to determine what types of messages should be logged to the Debug Console.
@@ -94,10 +96,10 @@ The following options enable you to modify the state of the target application w
 
 ## Customizing GDB or LLDB
 
-You can change the behavior of GDB or LLDB by setting the following options.
+You can change the behavior of GDB or LLDB by setting the following options:
 
 * #### `MIMode`
-  Indicates the debugger that VS Code will connect to. Must be set to `gdb` or `lldb`.  This is pre-configured on a per-operating system basis and can be changed as needed.
+  Indicates the debugger that VS Code will connect to. Must be set to `gdb` or `lldb`. This is pre-configured on a per-operating system basis and can be changed as needed.
 
 * #### `miDebuggerPath`
   The path to the debugger (such as gdb). When only the executable is specified, it will search the operating system's PATH variable for a debugger (GDB on Linux and Windows, LLDB on OS X).
@@ -152,7 +154,7 @@ The C/C++ extension enables debugging dump files on Windows and core dump files
   If you want to debug a Windows dump file, set this to the path to the dump file to start debugging in the `launch` configuration.
 
 * #### `coreDumpPath`
-  Full path to a core dump file to debug for the specified program.  Set this to the path to the core dump file to start debugging in the `launch` configuration.
+  Full path to a core dump file to debug for the specified program. Set this to the path to the core dump file to start debugging in the `launch` configuration.
 _Note: core dump debugging is not supported with MinGw._
 
 ## Remote debugging or debugging with a local debugger server
@@ -175,7 +177,7 @@ _Note: core dump debugging is not supported with MinGw._
 ## Additional properties
 
 * #### `processId`
-  Defaults to `${command.pickProcess}` which will display a list of available processes the debugger can attach to.  It is recommended to leave this default, but the property can be explicitly set to a specific process ID for the debugger to attach to.
+  Defaults to `${command.pickProcess}` which will display a list of available processes the debugger can attach to. It is recommended to leave this default, but the property can be explicitly set to a specific process ID for the debugger to attach to.
 
 * #### `request`
   Indicates whether the configuration section is intended to `launch` the program or `attach` to an already running instance.
@@ -184,7 +186,7 @@ _Note: core dump debugging is not supported with MinGw._
   `Deprecated` This option is no longer needed as the target architecture is automatically detected.
 
 * #### `type`
-  Indicates the underlying debugger being used. Must be `cppvsdbg` when using the Visual Studio Windows debugger, and `cppdbg` when using GDB or LLDB.  This is automatically set to the correct value when the
+  Indicates the underlying debugger being used. Must be `cppvsdbg` when using the Visual Studio Windows debugger, and `cppdbg` when using GDB or LLDB. This is automatically set to the correct value when the
 **launch.json** file is created.
 
 * #### `sourceFileMap`