Update for 0.22.1. (#3331)

microsoft · Mar 21, 2019 · 798e905 · 798e905
1 parent 1eb064e
commit 798e905
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/Extension/CHANGELOG.md b/Extension/CHANGELOG.md
@@ -1,8 +1,9 @@
 # C/C++ for Visual Studio Code Change Log
 
-## Version 0.22.1: March 20, 2019
+## Version 0.22.1: March 21, 2019
 * Fix `tasks.json` with single-line comments being overwritten when `Build and Debug Active File` is used. [#3327](https://github.com/Microsoft/vscode-cpptools/issues/3327)
 * Fix an invalid `compilerPath` property getting added to `tasks.json` after doing `Configure Task` with a C/C++ compiler.
+* Add IntelliSense caching for macOS 10.13 or later (0.22.0 only supported Windows and Linux).
 
 ## Version 0.22.0: March 19, 2019
 ### Major Changes

diff --git a/Extension/ReleaseNotes.html b/Extension/ReleaseNotes.html
@@ -208,7 +208,7 @@ <h1>Microsoft C/C++ Extension for VS Code</h1>
                                     <h2 class="caption">March 2019 Update</h2>
                                     <div>Thank you for installing the C/C++ extension! We're excited to announce the following features in the March update:<br/>
                                         <h3 style="font-weight: 600">IntelliSense caching</h3>
-                                        On Windows and Linux, the extension will now cache header information to improve IntelliSense speed for your code files. Support for macOS will be available in a future release.<br/>
+                                        The extension will now cache header information to improve IntelliSense speed for your code files.<br/>
                                         <br/>
                                         <em style="font-weight: 600">Please Note:</em> The extension writes the cache to disk in order to achieve this performance improvement. By default the cache files will be stored in your workspace
                                         folder's ".vscode" folder, but you can change this location by using the <code>"C_Cpp.intelliSenseCachePath"</code> setting. You can also control how much disk space can be

diff --git a/Extension/package.json b/Extension/package.json
@@ -1451,7 +1451,7 @@
   "runtimeDependencies": [
     {
       "description": "C/C++ language components (Linux / x86_64)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2065016",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2084924",
       "platforms": [
         "linux"
       ],
@@ -1465,7 +1465,7 @@
     },
     {
       "description": "C/C++ language components (Linux / x86)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2065017",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2085028",
       "platforms": [
         "linux"
       ],
@@ -1481,7 +1481,7 @@
     },
     {
       "description": "C/C++ language components (OS X)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2064955",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2084925",
       "platforms": [
         "darwin"
       ],
@@ -1492,7 +1492,7 @@
     },
     {
       "description": "C/C++ language components (Windows)",
-      "url": "https://go.microsoft.com/fwlink/?linkid=2065027",
+      "url": "https://go.microsoft.com/fwlink/?linkid=2085027",
       "platforms": [
         "win32"
       ],

diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts
@@ -383,13 +383,11 @@ class DefaultClient implements Client {
 
         let intelliSenseCacheDisabled: boolean = false;
         if (os.platform() === "darwin") {
-            intelliSenseCacheDisabled = true;
-            // TODO: Re-enable this after the performance is improved on Mac.
-            //const releaseParts: string[] = os.release().split(".");
-            //if (releaseParts.length >= 1) {
-            //    // AutoPCH doesn't work for older Mac OS's.
-            //    intelliSenseCacheDisabled = parseInt(releaseParts[0]) < 17;
-            //}
+            const releaseParts: string[] = os.release().split(".");
+            if (releaseParts.length >= 1) {
+                // AutoPCH doesn't work for older Mac OS's.
+                intelliSenseCacheDisabled = parseInt(releaseParts[0]) < 17;
+            }
         }
 
         let clientOptions: LanguageClientOptions = {