Change "C/C++ References" output panel to "C/C++ Peek References" and…

… create it when Peek occurs (#4363) * change output panel and create it when Peek occurs * create output pane only on peek references
microsoft · Oct 1, 2019 · 66b12b8 · 66b12b8
1 parent 346ee37
commit 66b12b8
Showing 1 changed file with 19 additions and 6 deletions.
diff --git a/Extension/src/LanguageServer/references.ts b/Extension/src/LanguageServer/references.ts
@@ -9,6 +9,7 @@ import { FindAllRefsView } from './referencesView';
 import * as telemetry from '../telemetry';
 import * as nls from 'vscode-nls';
 import { RenameView } from './renameView';
+import * as logger from '../logger';
 
 nls.config({ messageFormat: nls.MessageFormat.bundle, bundleFormat: nls.BundleFormat.standalone })();
 const localize: nls.LocalizeFunc = nls.loadMessageBundle();
@@ -162,8 +163,6 @@ export class ReferencesManager {
 
     initializeViews(): void {
         if (!this.viewsInitialized) {
-            this.referencesChannel = vscode.window.createOutputChannel(localize("c.cpp.references", "C/C++ References"));
-            this.disposables.push(this.referencesChannel);
             this.findAllRefsView = new FindAllRefsView();
             this.renameView = new RenameView();
             this.viewsInitialized = true;
@@ -340,12 +339,24 @@ export class ReferencesManager {
         this.referencesViewFindPending = false;
         this.clearViews();
 
+        if (this.client.ReferencesCommandMode === ReferencesCommandMode.Peek && !this.referencesChannel) {
+            this.referencesChannel = vscode.window.createOutputChannel(localize("c.cpp.peek.references", "C/C++ Peek References"));
+            this.disposables.push(this.referencesChannel);
+        }
+
         if (this.referencesStartedWhileTagParsing) {
             let msg: string = localize("some.references.may.be.missing", "[Warning] Some references may be missing, because workspace parsing was incomplete when {0} was started.",
                 referencesCommandModeToString(this.client.ReferencesCommandMode));
-            this.referencesChannel.appendLine(msg);
-            this.referencesChannel.appendLine("");
-            this.referencesChannel.show(true);
+            if (this.client.ReferencesCommandMode === ReferencesCommandMode.Peek) {
+                this.referencesChannel.appendLine(msg);
+                this.referencesChannel.appendLine("");
+                this.referencesChannel.show(true);
+            } else if (this.client.ReferencesCommandMode === ReferencesCommandMode.Find) {
+                let logChannel: vscode.OutputChannel = logger.getOutputChannel();
+                logChannel.appendLine(msg);
+                logChannel.appendLine("");
+                logChannel.show(true);
+            }
         }
 
         let currentReferenceCommandMode: ReferencesCommandMode = this.client.ReferencesCommandMode;
@@ -411,7 +422,9 @@ export class ReferencesManager {
     }
 
     public clearViews(): void {
-        this.referencesChannel.clear();
+        if (this.referencesChannel) {
+            this.referencesChannel.clear();
+        }
         this.findAllRefsView.show(false);
         this.renameView.show(false);
     }