Merge pull request #5466 from microsoft/bobbrow/downgradeFix

Fix a bug with downgrading
microsoft · May 12, 2020 · 17ddec4 · 17ddec4
2 parents 7b2eb67 + a4535a9
commit 17ddec4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Extension/src/githubAPI.ts b/Extension/src/githubAPI.ts
@@ -139,7 +139,8 @@ export async function getTargetBuildInfo(updateChannel: string): Promise<BuildIn
             // If the user version is greater than or incomparable to the latest available verion then there is no need to update
             const userVersion: PackageVersion = new PackageVersion(util.packageJson.version);
             const latestVersion: PackageVersion = new PackageVersion(builds[0].name);
-            if (!testingInsidersVsixInstall && ((userVersion.suffix && userVersion.suffix !== 'insiders') || (userVersion.isEqual(latestVersion)))) {
+            const latestIsCorrect: boolean = latestVersion.suffix !== 'insiders' || updateChannel === 'insiders';
+            if (!testingInsidersVsixInstall && ((userVersion.suffix && userVersion.suffix !== 'insiders') || (userVersion.isEqual(latestVersion) && latestIsCorrect))) {
                 return undefined;
             }