Adding support for Azure Cosmos DB for MongoDB API Emulator #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llKnownEmulatorPassword
…igration-emulator # Conflicts: # src/tree/AttachedAccountsTreeItem.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the handling of MongoDB emulator connections and refactor some existing code for better clarity and maintainability. The key changes include renaming a constant, adding a new wizard step for MongoDB emulator connections, and updating various methods to accommodate these changes.
Improvements to MongoDB Emulator Handling:
src/constants.ts: RenamedemulatorPasswordtowellKnownEmulatorPasswordto better reflect its purpose.src/commands/attachAccount/MongoEmulatorStep.ts: Added a newMongoEmulatorStepclass to handle the emulator connection confirmation.src/commands/attachAccount/AttachAccountWizardContext.ts: Added a new propertymongodbapiIsEmulatorto theAttachAccountWizardContextinterface.src/commands/attachAccount/attachAccount.ts: Updated theattachAccountfunction to include the newMongoEmulatorStep.Refactoring and Code Simplification:
src/commands/attachAccount/attachAccount.ts: Removed the redundantgetMongoCoreExperienceQuickPicksimport and updated thegetExperiencefunction to use a unified experience for Mongo connections. [1] [2]src/mongo/connectToMongoClient.ts: Updated theconnectToMongoClientfunction to accept anisEmulatorparameter and refactored theisCosmosEmulatorConnectionStringfunction to use the renamed constant. [1] [2]These changes enhance the clarity and functionality of the codebase, particularly in handling MongoDB emulator connections.