[Bugfix] Pass config to wandb, trace interval type check #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgrawalAmey
reviewed
Aug 24, 2024
AgrawalAmey
approved these changes
Aug 24, 2024
|
@nitinkedia7 can you approve the PR |
nitinkedia7
approved these changes
Aug 24, 2024
Hanchenli
pushed a commit
to XbzOnGit/vidur
that referenced
this pull request
Nov 8, 2024
* Bug fix: trace type, wandb config * make format * directly use SimulationConfig * make format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were few bugs:
self._config.to_dict()to config parameter ofwandb.init()resulted in error, becauseMetricsConfigdoes not haveto_dict()function.SyntheticRequestGeneratorclass.python -m vidur.main(without any CLI args) resulted in error mentioned in point 2. It tried to run vidur with trace request interval generator type, but we don't have dataset for that.Fixes:
num_requeststo some value instead of None for Synthetic request generator type, so thatpython -m vidur.mainruns without any additional args.