Backpressure tests didn't enable crash logging #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstantinosKoup
added a commit
to ConstantinosKoup/verona-rt
that referenced
this pull request
Apr 1, 2024
* Remove old variadic templates (microsoft#37) This PR removes the need for variadic templates when creating a behaviour, which was a leftover from the old C++ API. * Backpressure tests didn't enable crash logging (microsoft#38) * Improve perf benchmarking for immutable freeze (microsoft#36) * Improve perf benchmarking for immutable freeze This creates a series of benchmarks for immutable data structures. There are several patterns to increase the coverage of the algorithm from a performance point of view. * Linked List (Double and Single) * Balanced binary tree (nullptr for leaves, or root for leaves, i.e. cycle) * Balanced 4-tree (where each TreeNode is a 4 element linked list) * Parent pointing tree * Linked list with lots of backedges to various points. These cover some fairly deep cyclic structures that are designed to push the corner cases of performance. The output is generated in a way that is easy to graph. * Clangformat * Reduced time to get through CI --------- Co-authored-by: Marios Kogias <[email protected]> Co-authored-by: Matthew Parkinson <[email protected]>
ConstantinosKoup
pushed a commit
to ConstantinosKoup/verona-rt
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure in #14 is hard to diagnose. This change should make that easier by enabling crash logging for this test. Most tests get this automatically from the harness, but this is not using the standard harness as it is simulating external work.