-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ceres + downstreams] Update to ceres to 2.2.0 #42475
Merged
JavierMatosD
merged 70 commits into
microsoft:master
from
ahojnnes:user/jsch/ceres-2.2.0
Dec 13, 2024
Merged
Changes from 4 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
19a3b89
[ceres] Update to port version 2.2.0
ahojnnes 41e4fc1
d
ahojnnes e185abc
d
ahojnnes 73c312a
d
ahojnnes ba5ccff
d
ahojnnes 7bcc754
d
ahojnnes 14e6951
d
ahojnnes 68bea46
d
ahojnnes adbc51b
cartographer
ahojnnes 73085c9
d
ahojnnes 732c856
d
ahojnnes 31b6e60
d
ahojnnes 766d336
d
ahojnnes 7d3b7d5
d
ahojnnes c9242c4
d
ahojnnes 4dd9d75
d
ahojnnes df13a95
Merge branch 'master' of https://github.com/microsoft/vcpkg into user…
ahojnnes 0256b96
openturns
ahojnnes 823ed58
d
ahojnnes 41dc988
d
ahojnnes 476dacf
d
ahojnnes e7a4007
d
ahojnnes 343d558
d
ahojnnes 87cc0e3
d
ahojnnes 0d8fbbe
d
ahojnnes 874459b
d
ahojnnes 3e90198
d
ahojnnes 61edee3
d
ahojnnes 3a01806
d
ahojnnes a1b6112
d
ahojnnes 7663800
d
ahojnnes 7a949a7
d
ahojnnes b3f4dcd
d
ahojnnes 5d3f0c9
d
ahojnnes da61845
d
ahojnnes 7066000
d
ahojnnes 7e5f6f7
d
ahojnnes 3451349
d
ahojnnes abd2334
d
ahojnnes 6d436bc
d
ahojnnes 2cab7a0
d
ahojnnes a5b3f9a
d
ahojnnes 7c04c60
d
ahojnnes f85d663
d
ahojnnes 88cbb02
d
ahojnnes c65ee75
d
ahojnnes 3efe26c
d
ahojnnes 0a52491
d
ahojnnes 3bbe299
d
ahojnnes 8952607
d
ahojnnes 217782b
d
ahojnnes 30a17dc
d
ahojnnes 6e1e657
d
ahojnnes 303130f
d
ahojnnes 91494ff
d
ahojnnes 9b9c7f4
d
ahojnnes eb518c6
cr
ahojnnes dacc456
d
ahojnnes 79d503d
fix ceres
ahojnnes 503648f
d
ahojnnes 5bc2afd
fix
ahojnnes 03c42f4
d
ahojnnes db5a5e9
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal edf9d08
Deindex theia and cartrographer on the grounds that they require huge…
BillyONeal b5b3e51
Update ports/openmvg/portfile.cmake
ahojnnes 278d047
d
ahojnnes 4301643
d
ahojnnes c0d750d
Merge branch 'master' of https://github.com/microsoft/vcpkg into user…
ahojnnes 6b564c2
d
ahojnnes 54ea59f
d
ahojnnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,6 @@ | |
{ | ||
"name": "ceres", | ||
"features": [ | ||
"cxsparse", | ||
"suitesparse" | ||
] | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_package calls should never be QUIET in vcpkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the next few lines in the original config file, you will find that it is not really quiet but it fails if the find_package call was unsuccessful. It has some custom logic that alters internal variables. I suggest keeping the patch minimal, as the behavior will be the same.