-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuiteSparse] Update and split into sub-packages (v2) #41929
base: master
Are you sure you want to change the base?
Conversation
Parallel configure fails due to race conditions with configure_file().
…rom_github() To avoid having to download several versions of the source archive.
f05cdbf
to
72dbfc2
Compare
New error:
The error message from F:\PRreview\vcpkg\buildtrees\suitesparse-cholmod\config-x64-windows-dbg-err.log:
CUDA has been installed. |
Also improve the error messages for CUDA detection in CMake.
@LilyWangLL I now noticed that the project was always overriding CMAKE_CUDA_ARCHITECTURES. I fixed that and also made the CUDA detection error reporting more immediate and hopefully clearer. Can you try again? It builds with [cuda] enabled on Linux for me. I'll try on Windows as well, but later. |
2a02a04
to
58a09ee
Compare
Continues #39297.
Additional changes in this PR:
suitesparse
disabled by default.suitesparse-cxsparse
. This leaves it enabled by default, where it's supported - everything except MSVC.suitesparse-graphblas
to make it easier to use.Review comments that did not get addressed:
suitesparse
dependency with its individual components in Ceres and elsewhere to a separate PR.Let me know if I missed anything.
Fixes #24252.
./vcpkg x-add-version --all
and committing the result.