-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[log4cxx] Add 1.3.0 #41927
base: master
Are you sure you want to change the base?
[log4cxx] Add 1.3.0 #41927
Conversation
) | ||
|
||
vcpkg_extract_source_archive( | ||
SOURCE_PATH ARCHIVE "${ARCHIVE}" | ||
PATCHES | ||
fix-find-package.patch | ||
${MAKE_PKG_CONFIG_SUPPORT_OPT_IN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the port switch it on unconditionally and to fix it as needed.
FTR vcpkg_fixup_pkgconfig
is guarded by a positive-list condition. This is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the port switch it on unconditionally and to fix it as needed
This was the error when pkf_config support was on:
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:134 (message):
D:/downloads/tools/msys2/21caed2f81ec917b/mingw64/bin/pkg-config.exe
--exists liblog4cxx failed with error code: 1
ENV{PKG_CONFIG_PATH}: "D:/p/log4cxx_x64-windows-static/lib/pkgconfig;D:/p/log4cxx_x64-windows-static/share/pkgconfig;D:/installed/x64-windows-static/lib/pkgconfig;D:/installed/x64-windows-static/share/pkgconfig"
output: Package apr-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `apr-1.pc'
to the PKG_CONFIG_PATH environment variable
Package 'apr-1', required by 'liblog4cxx', not found
How would you fix that from the log4cxx port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be fix in this port indeed. Poor pkg-config support in apr
, unfortunately.
./vcpkg x-add-version --all
and committing the result.