Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log4cxx] Add 1.3.0 #41927

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

swebb2066
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

)

vcpkg_extract_source_archive(
SOURCE_PATH ARCHIVE "${ARCHIVE}"
PATCHES
fix-find-package.patch
${MAKE_PKG_CONFIG_SUPPORT_OPT_IN}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the port switch it on unconditionally and to fix it as needed.

FTR vcpkg_fixup_pkgconfig is guarded by a positive-list condition. This is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the port switch it on unconditionally and to fix it as needed

This was the error when pkf_config support was on:

CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:134 (message):
  D:/downloads/tools/msys2/21caed2f81ec917b/mingw64/bin/pkg-config.exe
  --exists liblog4cxx failed with error code: 1

      ENV{PKG_CONFIG_PATH}: "D:/p/log4cxx_x64-windows-static/lib/pkgconfig;D:/p/log4cxx_x64-windows-static/share/pkgconfig;D:/installed/x64-windows-static/lib/pkgconfig;D:/installed/x64-windows-static/share/pkgconfig"
      output: Package apr-1 was not found in the pkg-config search path.

  Perhaps you should add the directory containing `apr-1.pc'

  to the PKG_CONFIG_PATH environment variable

  Package 'apr-1', required by 'liblog4cxx', not found

How would you fix that from the log4cxx port?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be fix in this port indeed. Poor pkg-config support in apr, unfortunately.

@swebb2066 swebb2066 marked this pull request as ready for review November 6, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants