[vcpkg-make] Add new port #39050

JavierMatosD · 2024-05-30T22:43:39Z

Testing to see what happens when various options are on/off. Added a test port and cleaned up some of the code.

…vcpkg-make # Conflicts: # ports/vcpkg-make/vcpkg-make-common.cmake # ports/vcpkg-make/vcpkg-make.cmake

ports/vcpkg-make/portfile.cmake

scripts/test_ports/vcpkg-make-tests/test-z_vcpkg_make_determine_arch.cmake

ports/vcpkg-make/vcpkg_make_common.cmake

scripts/test_ports/vcpkg-make-tests/test-z_vcpkg_make_prepare_compile_flags.cmake

ports/vcpkg-make/vcpkg_make.cmake

JavierMatosD · 2024-10-22T18:50:08Z

I would like to repeat my concerns regarding parameters taking boolean values instead of choosing zero-parameter keywords without arguments.

@dg0yt, mind offering an example? I see a lot of places where we are passing boolean-like options such as DISABLE_CPP_FLAGS, NO_FLAG_ESCAPING, and DISABLE_MSVC_WRAPPERS. Are you suggesting these turn into keyword-like options like USE_CPP_FLAGS?

I took your previous comment to mean "don't compare cmake variables to any particular literal"

JavierMatosD · 2024-10-24T17:11:22Z

ports/vcpkg-make/vcpkg_make.cmake

+        message(FATAL_ERROR "${PORT} currently requires the following programs from the system package manager:
+        autoconf automake autoconf-archive
+    On Debian and Ubuntu derivatives:
+        sudo apt-get install autoconf automake autoconf-archive
+    On recent Red Hat and Fedora derivatives:
+        sudo dnf install autoconf automake autoconf-archive
+    On Arch Linux and derivatives:
+        sudo pacman -S autoconf automake autoconf-archive
+    On Alpine:
+        apk add autoconf automake autoconf-archive
+    On macOS:
+        brew install autoconf automake autoconf-archive\n")
+    endif()


@BillyONeal, are we ok with this messaging?

dg0yt · 2024-10-28T06:29:45Z

I took your previous comment to mean "don't compare cmake variables to any particular literal"

This was the must-have. And there still is:
https://github.com/microsoft/vcpkg/pull/39050/files#diff-ec85869615f18a9570937cbc887348e720f2c195157eefe38f9dad3660913a58R443

But this should not be needed at all with a zero-option keyword.

I would like to repeat my concerns regarding parameters taking boolean values instead of choosing zero-parameter keywords without arguments.

@dg0yt, mind offering an example? I see a lot of places where we are passing boolean-like options such as DISABLE_CPP_FLAGS, NO_FLAG_ESCAPING, and DISABLE_MSVC_WRAPPERS. Are you suggesting these turn into keyword-like options like USE_CPP_FLAGS?

Option	Owner	Type	❤️
`DISABLE_CPP_FLAGS`	n/a	n/a (using `git grep DISABLE_CPP_FLAGS`)	n/a
`DISABLE_CPPFLAGS`	vcpkg-make	zero-value	✔️
`NO_FLAG_ESCAPING`	vcpkg-make	zero-value	✔️
`DISABLE_MSVC_WRAPPERS`	vcpkg-make	zero-value	✔️
`VCPKG_TRANSFORM_LIBS`	vcpkg_make	one-value (requiring literal `"ON"`)	💥

VCPKG_TRANSFORM_LIBS is the only exception in the list, in vcpkg_make_common.cmake.

I see how this is initialized in the calling spots. But I am not convinced that this is a sufficient justification.

dg0yt

Zero-value VCPKG_TRANSFORM_LIBS option.

ports/vcpkg-make/vcpkg_make_common.cmake

scripts/test_ports/vcpkg-make-tests/test-z_adapt_lib_link_names.cmake

JavierMatosD · 2024-11-04T20:09:04Z

Hmmm, I wasn't able to reproduce the windows failures locally...

dg0yt · 2024-11-05T07:12:01Z

Hmmm, I wasn't able to reproduce the windows failures locally...

You probably tested the head of your branch (before the msys2 update),
not the merge commit in CI (after the msys2 update, before the gmp fix).
Just merge sync the branch again, so that CI runs a new merge commit.

JavierMatosD · 2024-11-05T23:38:08Z

ports/gmp/portfile.cmake

 if(VCPKG_HOST_IS_WINDOWS)
-    # dumpbin detection fails with autoconf 2.72
    set(ENV{WANT_AUTOCONF} 2.71)
-endif()
-vcpkg_configure_make(
-    SOURCE_PATH "${SOURCE_PATH}"
-    AUTOCONFIG
-    ADDITIONAL_MSYS_PACKAGES
+    vcpkg_acquire_msys(MSYS_ROOT
+        PACKAGES 
+            autoconf2.71
        DIRECT_PACKAGES
            "https://mirror.msys2.org/msys/x86_64/autoconf2.71-2.71-3-any.pkg.tar.zst"
-            dd312c428b2e19afd00899eb53ea4255794dea4c19d1d6dea2419cb6a54209ea2130d48abbc20af12196b9f628143436f736fbf889809c2c2291be0c69c0e306
+            "dd312c428b2e19afd00899eb53ea4255794dea4c19d1d6dea2419cb6a54209ea2130d48abbc20af12196b9f628143436f736fbf889809c2c2291be0c69c0e306"
+    )
+endif()


I doubt this will work like this. dumpbin detection is still failing.

./libtool: eval: line 10827: syntax error near unexpected token `|' ./libtool: eval: line 10827: `dumpbin.exe -symbols -headers .libs/libgmp.la-2.obj | | /usr/bin/sed -e '/^[BCDGRS][ ]/s/.*[ ]$[^ ]*$/\1,DATA/' | /usr/bin/sed -e '/^[AITW][ ]/s/.*[ ]//' | sort | uniq > .libs/gmp.exp' make[2]: *** [Makefile:890: libgmp.la] Error 2 make[1]: *** [Makefile:1005: all-recursive] Error 1 make: *** [Makefile:797: all] Error 2

This is another issue, cf. #41510.
With 2.72, the error was during configure.
This error is during make.

Between | |, there should be the expansion of $global_symbol_pipe.

dumpbin detection is still failing.

Indeed:

checking for BSD- or MS-compatible name lister (nm)... dumpbin.exe -symbols -headers checking the name lister (dumpbin.exe -symbols -headers) interface... BSD nm

configure has (with another autoconf version):

if $GREP 'External.*some_variable' conftest.out > /dev/null; then lt_cv_nm_interface="MS dumpbin" fi

GREP is (in current config.log):

GREP='/usr/bin/grep'

conftest.out has (in current config.log):

009 00000000 SECT3 notype External | some_variable

The question is: Why doesn't it reach lt_cv_nm_interface="MS dumpbin"?

Ah, wait, config.log says:

It was created by GNU MP configure 6.3.0, which was generated by GNU Autoconf 2.72. Invocation command line was

This is the incompatible version.

dg0yt · 2024-11-06T06:18:29Z

ports/gmp/portfile.cmake


 if(VCPKG_CROSSCOMPILING)
    set(ENV{HOST_TOOLS_PREFIX} "${CURRENT_HOST_INSTALLED_DIR}/manual-tools/${PORT}")
 endif()

 if(VCPKG_HOST_IS_WINDOWS)
-    # dumpbin detection fails with autoconf 2.72


Please leave the comment.

dg0yt · 2024-11-06T06:20:30Z

ports/gmp/portfile.cmake

-    SOURCE_PATH "${SOURCE_PATH}"
-    AUTOCONFIG
-    ADDITIONAL_MSYS_PACKAGES
+    vcpkg_acquire_msys(MSYS_ROOT


How is this passed to / used in vcpkg_make_configure?

Neumann-A added 30 commits August 15, 2023 15:11

vcpkg-make initial idea

b499ded

don't run ci

62eb284

Make vcpkg portfile execution debugable

fffa564

WIP

2e1d32a

more WIP

36ce65c

install wrappers

23d3308

keep the configure_make somewhere for reference

92457bf

add function to warn about spaces

ab57ae7

strip whitespaces

7918e80

WIP

d3b8148

determine configure triplet

1f56817

wip

3ee0aa0

WIP

799b4c8

WIP . move more stuff over.

eaf0b67

WIP: create vcpkg_make_install

c0dc7d7

Merge remote-tracking branch 'upstream/master' into vcpkg-make

c5381ab

WIP code tuning

3933374

rename function to z_vcpkg_make_get_configure_triplets

3952202

Merge branch 'vcpkg-make' of https://github.com/Neumann-A/vcpkg into …

407d3f8

…vcpkg-make # Conflicts: # ports/vcpkg-make/vcpkg-make-common.cmake # ports/vcpkg-make/vcpkg-make.cmake

add configure cache

0b0df8d

More wip

facb152

fix includes

55ab880

fix automatic file include

fb6f0b0

make gmp use the new stuff

1bf57d6

fix stuff to configure (build flags are missing somehow)

a3621d3

more fixes

02dab22

cleanup message

f9fc193

remove "

06dd260

adjust tasks to test gmp

051adc4

move logfile analysis

5a181bf

dg0yt mentioned this pull request Oct 19, 2024

[vcpkg scripts] use CMAKE_C_COMPILER_TARGET to detect cross-compilation #41651

Closed

dg0yt reviewed Oct 21, 2024

View reviewed changes

ports/vcpkg-make/portfile.cmake Outdated Show resolved Hide resolved

data-queue reviewed Oct 21, 2024

View reviewed changes

dg0yt reviewed Oct 21, 2024

View reviewed changes

ports/vcpkg-make/vcpkg_make.cmake Outdated Show resolved Hide resolved

Javier Matos added 5 commits October 22, 2024 11:06

minor changes

20e578b

change DISABLE_MSVC_FLAG_ESCAPING to DISABLE_MSVC_TRANSFORMATIONS

c48e0ac

version db

94c30c3

remove white space

9abb675

version db

bb99dbb

JavierMatosD dismissed BillyONeal’s stale review via bb99dbb October 22, 2024 18:12

test debug variants

99eeb08

don't compare against a particular literal

8a18d49

vicroms mentioned this pull request Oct 23, 2024

Document vcpkg_make_configure/install microsoft/vcpkg-docs#388

Open

JavierMatosD commented Oct 24, 2024

View reviewed changes

dg0yt reviewed Oct 28, 2024

View reviewed changes

Javier Matos added 3 commits October 31, 2024 16:50

apply dg0yts changes

1d3020a

version db

90ef0d0

merge

c6615f6

Javier Matos added 6 commits November 5, 2024 13:08

Merge remote-tracking branch 'upstream/master' into vcpkg_make_port

bb70588

gmp prefer autoconf 2.71

1372ea1

version db

a796472

fix vcpkg_acquire_msys call

9cd0de2

version db

5512566

Merge remote-tracking branch 'upstream/master' into vcpkg_make_port

11c5e98

JavierMatosD commented Nov 5, 2024

View reviewed changes

dg0yt reviewed Nov 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg-make] Add new port #39050

[vcpkg-make] Add new port #39050

JavierMatosD commented May 30, 2024 •

edited

Loading

JavierMatosD commented Oct 22, 2024

JavierMatosD Oct 24, 2024

dg0yt commented Oct 28, 2024

dg0yt left a comment

JavierMatosD commented Nov 4, 2024

dg0yt commented Nov 5, 2024

JavierMatosD Nov 5, 2024 •

edited

Loading

dg0yt Nov 6, 2024

dg0yt Nov 6, 2024

dg0yt Nov 6, 2024

dg0yt Nov 6, 2024 •

edited

Loading

dg0yt Nov 6, 2024

dg0yt Nov 6, 2024

dg0yt Nov 6, 2024

[vcpkg-make] Add new port #39050

Are you sure you want to change the base?

[vcpkg-make] Add new port #39050

Conversation

JavierMatosD commented May 30, 2024 • edited Loading

JavierMatosD commented Oct 22, 2024

JavierMatosD Oct 24, 2024

Choose a reason for hiding this comment

dg0yt commented Oct 28, 2024

dg0yt left a comment

Choose a reason for hiding this comment

JavierMatosD commented Nov 4, 2024

dg0yt commented Nov 5, 2024

JavierMatosD Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

dg0yt Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

dg0yt Nov 6, 2024

Choose a reason for hiding this comment

JavierMatosD commented May 30, 2024 •

edited

Loading

JavierMatosD Nov 5, 2024 •

edited

Loading

dg0yt Nov 6, 2024 •

edited

Loading