Skip to content

Conversation

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Jan 9, 2026

Alternative to: #1256

I created a test port that just writes 10'000 files:

set(INCLUDE_DIR "${CURRENT_PACKAGES_DIR}/include/${PORT}")
file(MAKE_DIRECTORY "${INCLUDE_DIR}")

foreach(i RANGE 1 10000)
    set(header_name "header${i}")
    file(WRITE "${INCLUDE_DIR}/${header_name}.h"
"// Generated header ${header_name}
#pragma once
constexpr int ${header_name}_value = ${i};
")
endforeach()

file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/share/${PORT}")
vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/copyright")

Testing before/after this change for vcpkg install testing-headers shows a meaningful performance improvement; I'm guessing due to antivirus involvement or similar

parallelism results

This is on AMD RYZEN AI MAX+ PRO 395 w/ Radeon 8060S

listfile_lines.push_back(list_listfile_line);
break;
}
case FileType::symlink:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub's diff is awful. This line should go with 185 on the 'red' side.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obligatory cult of Beyond Compare recruitment flyer:

a better diff of this function

Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyONeal BillyONeal merged commit 13ed91f into microsoft:main Jan 13, 2026
7 checks passed
@BillyONeal BillyONeal deleted the parallel-file-install branch January 13, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants