-
Notifications
You must be signed in to change notification settings - Fork 339
Install files in parallel, redux #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…flow in install_files_and_write_listfile
| listfile_lines.push_back(list_listfile_line); | ||
| break; | ||
| } | ||
| case FileType::symlink: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub's diff is awful. This line should go with 185 on the 'red' side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vicroms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Alternative to: #1256
I created a test port that just writes 10'000 files:
Testing before/after this change for
vcpkg install testing-headersshows a meaningful performance improvement; I'm guessing due to antivirus involvement or similarThis is on AMD RYZEN AI MAX+ PRO 395 w/ Radeon 8060S