dependencies.cpp optimizations #1891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
approved these changes
Jan 8, 2026
| std::unordered_set<PackageSpec> spec_set = {spec}; | ||
| // We want to batch as many dep_infos as possible, so look ahead in the frame and stack | ||
| std::unordered_set<PackageSpec> spec_set = {frame.spec}; | ||
| for (auto&& d : frame.deps) |
Member
There was a problem hiding this comment.
I hate the no {}s but that's what the other code in this function is doing so no change requested.
| it->second.overlay_or_override = true; | ||
| it->second.scfl = p_overlay; | ||
| } | ||
| else if (const auto over_it = m_overrides.find(spec.name()); over_it != m_overrides.end()) |
Member
There was a problem hiding this comment.
GitHub's diff is freaking awful as always. This is just deleting the unused Version ver and changing else { if into else if
No change requested.
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jan 8, 2026
Nitpicks I noticed while reviewing microsoft#1891
vicroms
pushed a commit
that referenced
this pull request
Jan 8, 2026
Nitpicks I noticed while reviewing #1891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collected while working on #1890.
Removes unused code.
Makes
batch_load_vars()handle all dependencies from the currentConstraintFramestack item. In particular, extends the initial batch when the stack is empty and the current frame already constains multiple dependencies from the top level manifest. OTOH it may have no effect at all because unbatched processing already collected the vars incommands.install.cpp.