Manually revert 87adc3f "Fix default features control by top level manifest (#1331)" #1889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#48892
I think the root cause of the issue was that the default features of the top level manifest were initially unknown and the graph was then stuck resolving the circular dependency between the individual features. This issue is now avoided because all features of the top level manifest are now already known beforehand.
I also added an e2e test based on the manifest from the original bug report. Note that I removed the boost-test dependency. I verified that the original bug could still be reproduced.