-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python multi namespace #5375
base: main
Are you sure you want to change the base?
Python multi namespace #5375
Conversation
…hon-multi-namespace
…hon-multi-namespace
…hon-multi-namespace
No changes needing a change description found. |
You can try these changes here
|
packages/http-client-python/generator/pygen/codegen/models/code_model.py
Show resolved
Hide resolved
@@ -300,9 +302,15 @@ def imports(self, async_mode: bool) -> FileImport: | |||
ImportType.SDKCORE, | |||
TypingSection.CONDITIONAL, | |||
) | |||
serialize_namespace = kwargs.get("serialize_namespace", self.code_model.namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me, the relative import path is always calculated by the self namespace and the the namespace of the type imported. why we need this serialize_namespace
arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
models can be imported in clients/models/operations so serialize_namespace
is used to make sure where it is serialized.
def get_relative_import_path( | ||
self, | ||
serialize_namespace: str, | ||
imported_namespace: Optional[str] = None, | ||
*, | ||
imported_namespace_type: NamespaceType = NamespaceType.CLIENT, | ||
async_mode: bool = False, | ||
filename: str = "", | ||
module_name: Optional[str] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this calculation much simple? just calculate a import namespace based on current namespace? do not do different kinds of concat in this function which make it not so responsibility independent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of signatures are used to calculate real imported_namespace
inner SDK so I am fine to split it into independent function.
packages/http-client-python/generator/pygen/codegen/models/code_model.py
Show resolved
Hide resolved
…hon-multi-namespace
For Azure/autorest.python#2795.
Compared to the previous logic that only supported a single namespace, this PR introduces support for multiple namespaces. This primarily requires updates in two key areas:
imports
function.Considering these two main changes, here's a detailed summary of the updates in this PR:
enable-typespec-namespace
, which lets users decide if they want to support native typespec namespace.clientNamespace
for models/operations/enums/namedUnions/clients: the emitter usesclientNamespace
to determine the exact location where the target type should be.get_relative_import_path
for CodeModel: all relative import paths should be calculated using this function.client_namespace_types
to CodeModel: it counts and stores all namespace types and information aboutclients/operation_groups/enums/models
in each namespace.client_namespace_types
property in CodeModel, we can cycle through each namespace and serialize its clients/models/enums/operations using the same logic.relative_path
andoperation
kwargs, which were not set from the top caller but from various functions during the calling process. The signatures were difficult to understand and maintain. I replaces them with the newserialize_namespace
andserialize_namespace_type
kwargs. Now, any function that needs to calculate relative imports can use these two parameters, which are set from the top caller, making them easier to understand and maintain.