Generate Code from TypeSpec in VSCode #5312
Conversation
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
ide
There was a problem hiding this comment.
some icons don't work well in dark theme.
There was a problem hiding this comment.
Update the most icons. except java for dark themes.
| } | ||
| const outputDir = path.join( | ||
| baseDir, | ||
| selectedEmitter.emitterKind, |
There was a problem hiding this comment.
please put the output folder under tsp-output as default. the "server", "client" is too general which user may already use in his project...
There was a problem hiding this comment.
@RodgeFu We need consistent the output folder structure as the toDoApp. Arch will discuss the folder structure, and update accordingly when toDoApp folder structure finalized.
| if (npmInstallResult.exitCode !== 0) { | ||
| logger.error( | ||
| `Error occurred when installing packages.`, | ||
| [`${npmInstallResult.stderr}`], |
There was a problem hiding this comment.
got following error when trying upgrade lib and generating client java. in the error, it mentions resolving "undefined@undefined", please double check...
There was a problem hiding this comment.
same as issue #5385.
There was a problem hiding this comment.
no, i mean this line. is the "undefined@undefined" expected?
There was a problem hiding this comment.
undefined@undefined does not refer to the variable of our code. It is reported by npm referring to its own variables.
Yes, it is expected when npm install failure because of dependency conflict.
| } | ||
| } | ||
| }, | ||
| "default": [ |
There was a problem hiding this comment.
@RodgeFu, looks like we are baking a list of known 1P emitters in the extension packages. We have discussed this being built-in template driven. I would also like to re-review design of the Generate Code flow. I have comments on what's listed in the design doc on this.
There was a problem hiding this comment.
Fix #5025
Fix #5463
Integrate Code Generation in VSCode extension